Give a better message from 'zpool get' when an invalid pool name is provided #15942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If you do
zpool get name foo
, but you have no pool named "foo", the error message you get is very confusing:This error message is pretty confusing and misleading, given that a pool name was provided. It just happens to not be the name of an existing pool. We should give a clearer error message.
Description
We give a clearer error message:
We also no longer print the usage in that case, since it takes up a lot of space and makes it hard to see the error message. The error message itself makes it clear what is expected in that spot.
How Has This Been Tested?
Manual testing.
Types of changes
Checklist:
Signed-off-by
.