Add ashift validation when adding devices to a pool #15509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grwilson
force-pushed
the
ashift_validate
branch
2 times, most recently
from
d66a627
to
91cd782
Compare
behlendorf
reviewed
Dec 5, 2023
grwilson
force-pushed
the
ashift_validate
branch
3 times, most recently
from
64fd09b
to
6e09ec9
Compare
mmaybee
reviewed
Feb 28, 2024
mmaybee
approved these changes
Mar 5, 2024
grwilson
force-pushed
the
ashift_validate
branch
from
1f15a05
to
d2b50b3
Compare
amotin
reviewed
Mar 5, 2024
grwilson
force-pushed
the
ashift_validate
branch
from
d2b50b3
to
5c26cfe
Compare
amotin
approved these changes
Mar 7, 2024
behlendorf
approved these changes
Mar 8, 2024
behlendorf
added
Status: Accepted
|
Based on some offline discussions, I modified the command line option to be more explicit. I would appreciate feedback on the new proposal. |
grwilson
force-pushed
the
ashift_validate
branch
from
be505ad
to
30ba207
Compare
grwilson
force-pushed
the
ashift_validate
branch
from
30ba207
to
ab99001
Compare
behlendorf
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Using unique long options for this seems like a perfectly good way to handle this. Having to specify multiple options might result in a slightly longer command line than --allow= but that doesn't matter. Plus not having to add custom parsing for this is nice.
--allow-in-use
--allow-ashift-mismatch
--allow-replicaton-mismatch
If you can resolve the recently introduced conflicts this LGTM. Thanks!
grwilson
force-pushed
the
ashift_validate
branch
3 times, most recently
from
8f9e68f
to
4a95218
Compare
Currently, zpool add allows users to add top-level vdevs that have different ashifts but doing so prevents users from being able to perform a top-level vdev removal. Often times consumers may not realize that they have mismatched ashifts until the top-level removal fails. This feature adds ashift validation to the zpool add command and will fail the operation if the sector size of the specified vdev does not match the existing pool. This behavior can be disabled by using the -f flag. In addition, new flags have been added to provide fine-grained control to disable specific checks. These flags are: --allow-in-use --allow-ashift-mismatch --allow-replicaton-mismatch The force flag will disable all of these checks. Signed-off-by: George Wilson <gwilson@delphix.com>
grwilson
force-pushed
the
ashift_validate
branch
from
4a95218
to
6aac4be
Compare
tonyhutter
pushed a commit
that referenced
this pull request
May 2, 2024
Currently, zpool add allows users to add top-level vdevs that have different ashifts but doing so prevents users from being able to perform a top-level vdev removal. Often times consumers may not realize that they have mismatched ashifts until the top-level removal fails. This feature adds ashift validation to the zpool add command and will fail the operation if the sector size of the specified vdev does not match the existing pool. This behavior can be disabled by using the -f flag. In addition, new flags have been added to provide fine-grained control to disable specific checks. These flags are: --allow-in-use --allow-ashift-mismatch --allow-replicaton-mismatch The force flag will disable all of these checks. Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Mark Maybee <mmaybee@delphix.com> Signed-off-by: George Wilson <gwilson@delphix.com> Closes #15509
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
Currently, zpool add allows users to add top-level vdevs that have different ashifts but doing so prevents users from being able to perform a top-level vdev removal. Often times consumers may not realize that they have mismatched ashifts until the top-level removal fails. This feature adds ashift validation to the zpool add command and will fail the operation if the sector size of the specified vdev does not match the existing pool. This behavior can be disabled by using the -f flag. In addition, new flags have been added to provide fine-grained control to disable specific checks. These flags are: --allow-in-use --allow-ashift-mismatch --allow-replicaton-mismatch The force flag will disable all of these checks. Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Mark Maybee <mmaybee@delphix.com> Signed-off-by: George Wilson <gwilson@delphix.com> Closes openzfs#15509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
zpool addallows users to add top-level vdevs that have different ashifts but doing so prevents users from being able to perform a top-level vdev removal. Often times consumers may not realize that they have mismatched ashifts until the top-level removal fails.This feature adds ashift validation to the zpool add command and will fail the operation if the sector size of the specified vdev does not match the existing pool. In addition a new flag, -a, is added to the command to disable the ashift validation checks.