Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man: Add vdevprops.7 to the Makefile #14527

Merged
merged 1 commit into from
Feb 28, 2023
Merged

man: Add vdevprops.7 to the Makefile #14527

merged 1 commit into from
Feb 28, 2023

Conversation

debdrup
Copy link
Contributor

@debdrup debdrup commented Feb 24, 2023

Adding vdevprops.7 to the Makefile ensures that it gets installed properly on FreeBSD.

Motivation and Context

Without this change, there's no manual page for vdevprops shipped with the FreeBSD base system, and it's only available via the openzfs-docs.

Description

I'm not sure I can add any more words to describe this tiny change.

How Has This Been Tested?

Types of changes

  • Documentation (a change to man pages or other documentation)

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Feb 25, 2023
Copy link
Contributor

@allanjude allanjude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-By: Allan Jude <allan@klarasystems.com>

@behlendorf
Copy link
Contributor

@debdrup if you can add your signed of by to this commit, git commit --amend -s, and force update the PR I'll get this merged.

Adding vdevprops.7 to the Makefile ensures that it gets installed properly on FreeBSD.

Signed-off-by: Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
@debdrup debdrup changed the title Add vdevprops.7 to the Makefile man: Add vdevprops.7 to the Makefile Feb 27, 2023
@debdrup
Copy link
Contributor Author

debdrup commented Feb 27, 2023

With a bit of help from Richard, I got there in the end.

@behlendorf behlendorf merged commit 4b9bc63 into openzfs:master Feb 28, 2023
@debdrup debdrup deleted the patch-1 branch February 28, 2023 12:59
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 3, 2023
Adding vdevprops.7 to the Makefile ensures that it gets installed
properly on FreeBSD.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
Closes openzfs#14527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants