Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence unused-but-set-variable warning #13507

Merged
merged 1 commit into from
May 26, 2022
Merged

Silence unused-but-set-variable warning #13507

merged 1 commit into from
May 26, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 25, 2022

Motivation and Context

This was breaking the kmod port build on FreeBSD with Clang 13.

Description

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

How Has This Been Tested?

Building the kmod in the same way the port does (directly with make rather than configuring and using gmake like the CI does) errors out before this change and succeeds after it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Silence unused-but-set-variable warning
c0f4ca5 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@behlendorf behlendorf added Type: Building Indicates an issue related to building binaries Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 25, 2022
@behlendorf behlendorf merged commit b628292 into openzfs:master May 26, 2022
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 26, 2022
@behlendorf
Silence unused-but-set-variable warning
2d1ccf3 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
behlendorf pushed a commit that referenced this pull request May 27, 2022
@behlendorf
Silence unused-but-set-variable warning
090bda5 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #13507
@ghost ghost deleted the dn-unused branch May 30, 2022 19:43
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nicman23
Silence unused-but-set-variable warning
3ac4740 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nicman23
Silence unused-but-set-variable warning
102921e 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 12, 2022
@lundman
Silence unused-but-set-variable warning
50ae6e0 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@beren12
Silence unused-but-set-variable warning
8b86fe9 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
a97b12f 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
6835040 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
633829a 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
84732a2 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
9852862 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
e022d65 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
73b3722 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
5afd5a6 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
c1faf6d 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
11332f6 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
9e5a746 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
732b86a 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
ac0fbb6 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
ad27ccb 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
3c0cb40 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
38bd644 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
30f8b5f 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
b39d106 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
9ecfc86 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
f77118b 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
ac3a5ed 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
1714a27 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
b8ab496 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
10bd9a7 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
cb27ddf 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
8fe3a7e 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@andrewc12
Silence unused-but-set-variable warning
519b890 
This was breaking the kmod port build on FreeBSD with Clang 13.

Use the same trick as we do for ASSERT() to make DNODE_VERIFY() use
its parameter at compile time without actually using it at run time
in non-debug builds.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#13507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behlendorf