Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automake: don't install /e/d/zfs or /e/z/zfs-functions +x #13503

Merged
merged 1 commit into from
May 25, 2022
Merged

automake: don't install /e/d/zfs or /e/z/zfs-functions +x #13503

merged 1 commit into from
May 25, 2022

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented May 24, 2022 •
edited
Loading

Motivation and Context

#13496

Description

_SCRIPTS means it's made +x when installing; _DATA is made -x

How Has This Been Tested?

make install,

-rw-r--r-- 1 nabijaczleweli users 4.4K May 25 01:03 /tmp/dest/etc/default/zfs
-rw-r--r-- 1 nabijaczleweli users 9.3K May 25 01:03 /tmp/dest/usr/local/etc/zfs/zfs-functions

A few cursory git greps point toward these being the only affected files (well, in this direction, anyway; the other direction is more obvious so we're probably fine there).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli nabijaczleweli changed the title automake: don't distribute /e/d/zfs or /e/z/zfs-functions +x automake: don't install /e/d/zfs or /e/z/zfs-functions +x May 24, 2022
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this pull request May 24, 2022
@nabijaczleweli
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
b364c95 
Closes openzfs#13496
Backport-of: openzfs#13503
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
7009b89 
Closes openzfs#13496
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli mentioned this pull request May 24, 2022
Merged
13 tasks
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 25, 2022
@behlendorf behlendorf merged commit 1d89b98 into openzfs:master May 25, 2022
behlendorf pushed a commit that referenced this pull request May 25, 2022
@nabijaczleweli @behlendorf
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
96c7c63 
Closes #13496
Backport-of: #13503
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
0ee4cf0 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
d19e198 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 12, 2022
@nabijaczleweli @lundman
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
0c10ac3 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@nabijaczleweli @beren12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
f0c468b 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
92b6ee0 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
ea01c75 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
c15f430 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
0d725b1 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
395a541 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
a9d340c 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
9ea83f9 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
d12cc11 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
05f9594 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
d2ce530 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
7992cb3 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
c26809b 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
c9f1596 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
ec17166 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
ad7da76 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
fb9e038 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
dc092d6 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
3e07338 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
858f8c4 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
51cff8e 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
3789729 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
3e89aeb 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
fd54f16 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
2e0cf7f 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
e5f7ece 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
e94fcfd 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
automake: don't install /e/d/zfs or /e/z/zfs-functions +x
5e5e354 
_SCRIPTS means it's made +x when installing; _DATA is made -x.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#13496
Closes openzfs#13503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabijaczleweli @behlendorf