Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v' #13031

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v' #13031

merged 1 commit into from
Feb 3, 2022

Conversation

akashb-22
Copy link
Contributor

This commit adds enumerated names to disambiguate between the different vdevs.
Previously only 'zpool status' showed enumerated vdev names, now 'zpool list -v'
and 'zpool iostat -v' also shows the enumerated vdev names.

Signed-off-by: Akash B akash-b@hpe.com
Issue #12510

Motivation and Context

Add enumerated names to (zpool-list, zpool-iostat) commands similar to 'zpool status'.

Description

Currently on issuing zpool-status VDEV_NAME_TYPE_ID name_flags is passed to zpool_vdev_name() while getting the vdev names and this flag is not passed while issuing zpool-list and zpool-iostat commands. Due to this, the top level vdevs do not have the enumerated names in zpool-list and zpool-iostat commands.
Passing VDEV_NAME_TYPE_ID name_flags to zpool_vdev_name() gives enumerated vdev names on zpool-list and zpool-iostat commands.

How Has This Been Tested?

  1. Manually tested zpool-list and zpool-iostat commands with various zpool configurations, which shows the enumerated vdev names which matches with the zpool status command.
  2. Have run ZTS/ZLOOP tests with the fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@akashb-22 akashb-22 force-pushed the vdev_enum branch 3 times, most recently from f025ed4 to 1fc3dd0 Compare February 1, 2022 09:18
@akashb-22
Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v'
4efc923 
This commit adds enumerated names to disambiguate between the
different vdevs. Previously only 'zpool status' showed enumerated
vdev names, now 'zpool list -v' and 'zpool iostat -v' also shows
the enumerated vdev names.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Issue openzfs#12510
ghoshdipak
ghoshdipak approved these changes Feb 2, 2022
View reviewed changes
Copy link

@ghoshdipak ghoshdipak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the output is aligned with zpool status.

behlendorf
behlendorf approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks adding this support to make the output consistent.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Feb 2, 2022
@behlendorf behlendorf merged commit 7b468ed into openzfs:master Feb 3, 2022
@akashb-22 akashb-22 deleted the vdev_enum branch February 4, 2022 04:29
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@akashb-22 @tonyhutter
Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v'
79843b6 
This commit adds enumerated names to disambiguate between the
different vdevs. Previously only 'zpool status' showed enumerated
vdev names, now 'zpool list -v' and 'zpool iostat -v' also shows
the enumerated vdev names.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12510
Closes openzfs#13031
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 14, 2022
@akashb-22 @tonyhutter
Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v'
1e62958 
This commit adds enumerated names to disambiguate between the
different vdevs. Previously only 'zpool status' showed enumerated
vdev names, now 'zpool list -v' and 'zpool iostat -v' also shows
the enumerated vdev names.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12510
Closes openzfs#13031
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 16, 2022
@akashb-22 @tonyhutter
Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v'
a00d123 
This commit adds enumerated names to disambiguate between the
different vdevs. Previously only 'zpool status' showed enumerated
vdev names, now 'zpool list -v' and 'zpool iostat -v' also shows
the enumerated vdev names.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12510
Closes openzfs#13031
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 17, 2022
@akashb-22 @tonyhutter
Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v'
9221ff1 
This commit adds enumerated names to disambiguate between the
different vdevs. Previously only 'zpool status' showed enumerated
vdev names, now 'zpool list -v' and 'zpool iostat -v' also shows
the enumerated vdev names.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12510
Closes openzfs#13031
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@akashb-22 @nicman23
Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v'
83b2b09 
This commit adds enumerated names to disambiguate between the
different vdevs. Previously only 'zpool status' showed enumerated
vdev names, now 'zpool list -v' and 'zpool iostat -v' also shows
the enumerated vdev names.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12510
Closes openzfs#13031
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@akashb-22 @nicman23
Add enumerated vdev names to 'zpool iostat -v' and 'zpool list -v'
a6facd0 
This commit adds enumerated names to disambiguate between the
different vdevs. Previously only 'zpool status' showed enumerated
vdev names, now 'zpool list -v' and 'zpool iostat -v' also shows
the enumerated vdev names.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes openzfs#12510
Closes openzfs#13031
npc203 added a commit to npc203/zfs that referenced this pull request Aug 29, 2022
@npc203
Fix column width in 'zpool iostat -v' and 'zpool list -v'
a6ba066 
This commit fixes a minor spacing issue caused when enumerating vdev names, originates from openzfs#13031

Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
npc203 added a commit to npc203/zfs that referenced this pull request Aug 29, 2022
@npc203
Fix column width in 'zpool iostat -v' and 'zpool list -v'
11b4378 
This commit fixes a minor spacing issue caused when enumerating vdev names, originates from openzfs#13031

Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
npc203 added a commit to npc203/zfs that referenced this pull request Aug 29, 2022
@npc203
Fix column width in 'zpool iostat -v' and 'zpool list -v'
549a3ec 
This commit fixes a minor spacing issue caused when enumerating vdev names, originates from openzfs#13031

Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
npc203 added a commit to npc203/zfs that referenced this pull request Aug 29, 2022
@npc203
Fix column width in 'zpool iostat -v' and 'zpool list -v'
7c82c9f 
This commit fixes a minor spacing issue caused when enumerating vdev names, originates from openzfs#13031

Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
npc203 added a commit to npc203/zfs that referenced this pull request Aug 29, 2022
@npc203
Fix column width in 'zpool iostat -v' and 'zpool list -v'
ffa1c0c 
This commit fixes a minor spacing issue caused when enumerating vdev names, which originated from openzfs#13031

Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
@npc203 npc203 mentioned this pull request Aug 29, 2022
Merged
13 tasks
npc203 added a commit to npc203/zfs that referenced this pull request Aug 30, 2022
@npc203
Fix column width in 'zpool iostat -v' and 'zpool list -v'
c19d64e 
This commit fixes a minor spacing issue caused when
enumerating vdev names, which originated from openzfs#13031

Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
behlendorf pushed a commit that referenced this pull request Sep 6, 2022
@npc203
Fix column width in 'zpool iostat -v' and 'zpool list -v'
7c0e394 
This commit fixes a minor spacing issue caused when
enumerating vdev names, which originated from #13031

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
Closes #13811
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2022
@npc203 @tonyhutter
Fix column width in 'zpool iostat -v' and 'zpool list -v'
aa9e887 
This commit fixes a minor spacing issue caused when
enumerating vdev names, which originated from openzfs#13031

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
Closes openzfs#13811
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@npc203 @beren12
Fix column width in 'zpool iostat -v' and 'zpool list -v'
e6e0d95 
This commit fixes a minor spacing issue caused when
enumerating vdev names, which originated from openzfs#13031

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
Closes openzfs#13811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghoshdipak ghoshdipak ghoshdipak approved these changes

@behlendorf behlendorf behlendorf approved these changes

@richardelling richardelling Awaiting requested review from richardelling

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akashb-22 @behlendorf @ghoshdipak