Skip to content

Commit

Permalink
Revert "Temporarily disable Direct IO by default"
Browse files Browse the repository at this point in the history
This partially reverts commit 4121059.  Now that b4e4cbe has
been merged Direct IO can be enabled by default for Linux, but
for FreeBSD there still remains a potentially insufficient range
locking in zfs_getpages() which needs to be resolved.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
  • Loading branch information
behlendorf committed Oct 11, 2024
1 parent 97ba7c2 commit f674558
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions module/zfs/zfs_vnops.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,15 @@ static int zfs_bclone_wait_dirty = 0;
* Enable Direct I/O. If this setting is 0, then all I/O requests will be
* directed through the ARC acting as though the dataset property direct was
* set to disabled.
*
* Disabled by default on FreeBSD until a potential range locking issue in
* zfs_getpages() can be resolved.
*/
#ifdef __FreeBSD__
static int zfs_dio_enabled = 0;
#else
static int zfs_dio_enabled = 1;
#endif


/*
Expand Down

0 comments on commit f674558

Please sign in to comment.