This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
yurt-app-manager support YurtAppDaemon CRD #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kadisi <iamkadisi@163.com>
Signed-off-by: kadisi <iamkadisi@163.com>
Signed-off-by: kadisi <iamkadisi@163.com>
Signed-off-by: kadisi <iamkadisi@163.com>
Signed-off-by: kadisi <iamkadisi@163.com>
Signed-off-by: kadisi <iamkadisi@163.com>
Signed-off-by: kadisi <iamkadisi@163.com>
rambohe-ch
reviewed
Nov 16, 2021
rambohe-ch
reviewed
Nov 16, 2021
pkg/yurtappmanager/webhook/yurtappdaemon/validating/yurtappdaemon_create_update_handler.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Nov 16, 2021
rambohe-ch
reviewed
Nov 16, 2021
pkg/yurtappmanager/controller/yurtappdaemon/yurtappdaemon_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Nov 16, 2021
pkg/yurtappmanager/controller/yurtappdaemon/yurtappdaemon_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Nov 16, 2021
pkg/yurtappmanager/controller/yurtappdaemon/yurtappdaemon_controller.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Nov 16, 2021
pkg/yurtappmanager/webhook/yurtappdaemon/mutating/yurtappdaemon_create_update_handler.go
Show resolved
Hide resolved
Signed-off-by: kadisi <iamkadisi@163.com>
kadisi
force-pushed
the
new_yurt_app_daemon
branch
from
511ad61 to
1fa2de7
Compare
|
@rambohe-ch PTAL |
|
/lgtm |
rambohe-ch
approved these changes
Nov 30, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadisi, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
In the edge scenario, compute nodes in different regions are assigned to the same node pool. We expect some workload to be created automatically with the creation of the node pool. No additional human intervention is required.
ref: openyurtio/openyurt#433
ref: openyurtio/openyurt#422
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/assign @rambohe-ch @Fei-Guo
Please focus on the following files：
/pkg/yurtappmanager/controller/yurtappdaemon/yurtappdaemon_controller.go
/yurtappmanager/webhook/yurtappdaemon/mutating/yurtappdaemon_create_update_handler.go
r/pkg/yurtappmanager/webhook/yurtappdaemon/validating/yurtappdaemon_create_update_handler.go
Does this PR introduce a user-facing change?
other Note