Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DrmagicE as reviewer of OpenYurt #559

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Add DrmagicE as reviewer of OpenYurt #559

merged 1 commit into from
Nov 5, 2021

Conversation

DrmagicE
Copy link
Member

@DrmagicE DrmagicE commented Nov 5, 2021

GitHub Username

@DrmagicE

Organization you are requesting membership in

openyurtio

Sponsors

@rambohe-ch

Requirements

  • I have joined in the community [Dingding] and [WeChat]
  • I often attend Openyurt Community Week
  • I have reviewed the [community membership docs]
  • I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
  • I have checked my affiliation in [devstats] (if it's not correct, please fix in [cncf/gitdm])
  • I am actively contributing to 1 or more OpenYurt subprojects

List of your contributions

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 5, 2021
@rambohe-ch
Copy link
Member

@DrmagicE welcome you to apply OpenYurt reviewer. agree +1

@adamzhoul
Copy link
Member

agree +1

2 similar comments
@qclc
Copy link
Member

qclc commented Nov 5, 2021

agree +1

@Peeknut
Copy link
Member

Peeknut commented Nov 5, 2021

agree +1

@SataQiu
Copy link
Member

SataQiu commented Nov 5, 2021

+1

Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rambohe-ch
Copy link
Member

@DrmagicE Congratulations to you as reviewer, and you can check the reviewer's responsibilities and privileges here: https://github.com/openyurtio/community/blob/main/community-membership.md#reviewer

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DrmagicE, rambohe-ch, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Nov 5, 2021
@openyurt-bot openyurt-bot merged commit 884374a into openyurtio:master Nov 5, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants