add DeleteYurthubSetting to revert

[adamzhoul]

What type of PR is this?

/kind bug

What this PR does / why we need it:

clean all resource, when do revert

Which issue(s) this PR fixes:

Fixes #489

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

[openyurt-bot]

@adamzhoul: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

clean all resource, when do revert

Which issue(s) this PR fixes:

Fixes #489

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rambohe-ch]

@adamzhoul Another resource named yurt-hub-cfg confgmap has been added for yurthub, how about add create/delete yurt-hub-cfg configmap for yurthub?

The definition of yurt-hub-cfg configmap is here: https://github.com/openyurtio/openyurt/blob/master/config/setup/yurthub-cfg.yaml#L42-L48

[adamzhoul]

is this using now？ I can't find any place using this yet.
besides： do you mean put clusterrolebinding 、clusterrole configs into configmap , use operator to create or delete resource?

[rambohe-ch]

is this using now？ I can't find any place using this yet.
besides： do you mean put clusterrolebinding 、clusterrole configs into configmap , use operator to create or delete resource?

@adamzhoul This configmap is used by yurthub. so we need to add creation of this configmap in https://github.com/openyurtio/openyurt/blob/master/pkg/yurtctl/util/kubernetes/apply_addons.go#L206-L218. not add clusterrolebinding 、clusterrole configs into configmap.

[rambohe-ch]

is this using now？ I can't find any place using this yet.
besides： do you mean put clusterrolebinding 、clusterrole configs into configmap , use operator to create or delete resource?

@adamzhoul yurthub list/watch this configmap at here: https://github.com/openyurtio/openyurt/blob/master/pkg/yurthub/cachemanager/cache_agent.go#L98-L105

[adamzhoul]

now I understand.
I will put create in :

openyurt/pkg/yurtctl/util/kubernetes/apply_addons.go

Lines 206 to 218 in 32df8c2

	func DeployYurthubSetting(client *kubernetes.Clientset) error {
	// 1. create the ClusterRole
	if err := CreateClusterRoleFromYaml(client, edgenode.YurthubClusterRole); err != nil {
	return err
	}
	// 2. create the ClusterRoleBinding
	if err := CreateClusterRoleBindingFromYaml(client, edgenode.YurthubClusterRoleBinding); err != nil {
	return err
	}
	return nil
	}

and put delete in the new function DeleteYurthubSetting.

[rambohe-ch]

/lgtm
/approve

[openyurt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamzhoul, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rambohe-ch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment