Update config.go #491
Merged
Update config.go #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it maybe null point
Fei-Guo
reviewed
Sep 23, 2021
| @@ -164,6 +164,9 @@ func Complete(options *options.YurtHubOptions) (*YurtHubConfiguration, error) { | |||
| } | |||
|
|
|||
| func parseRemoteServers(serverAddr string) ([]*url.URL, error) { | |||
| if serverAddr == "" { | |||
| return make([]*url.URL, 0), fmt.Errorf("--server-addr should be set for hub agent") | |||
There was a problem hiding this comment.
We have line 189 below which should protect the case that serverAddr is "".
There was a problem hiding this comment.
We have line 189 below which should protect the case that serverAddr is "".
@Fei-Guo I think that line 189 will check resolved serverAddress, and this pr only check the parameter at the func entry. so i think that this pr makes sense.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fei-Guo, guoguodan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
YRXING
pushed a commit
to YRXING/openyurt
that referenced
this pull request
Oct 9, 2021
it maybe null point
MrGirl
pushed a commit
to MrGirl/openyurt
that referenced
this pull request
Mar 29, 2022
it maybe null point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it maybe null point