Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add more nodes for --cloud-nodes #459

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

adamzhoul
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

two points here:

  1. update description about convert.

this update is for better understating.
the command below is to convert with one node as a cloud node. same as the logic thought.

  1. add a note, how to use "," to add more nodes for --cloud-nodes params

this is useful when we deploy our openYurt cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

@openyurt-bot
Copy link
Collaborator

@adamzhoul: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind documentation

What this PR does / why we need it:

two points here:

  1. update description about convert.

this update is for better understating.
the command below is to convert with one node as a cloud node. same as the logic thought.

  1. add a note, how to use "," to add more nodes for --cloud-nodes params

this is useful when we deploy our openYurt cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

Welcome @adamzhoul! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Sep 9, 2021
@adamzhoul
Copy link
Member Author

/assign @yixingjia
please have a look.

@rambohe-ch
Copy link
Member

@adamzhoul Very appreciate you for improving the document of OpenYurt. and welcome you to apply for OpenYurt community member. you can get apply example here: openyurtio/community#23

@adamzhoul
Copy link
Member Author

@adamzhoul Very appreciate you for improving the document of OpenYurt. and welcome you to apply for OpenYurt community member. you can get apply example here: openyurtio/community#23

@rambohe-ch thanks for your inviting. will do it soon.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamzhoul, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 10, 2021
@openyurt-bot openyurt-bot merged commit 03122c8 into openyurtio:master Sep 10, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Co-authored-by: zhoulei5 <zhoulei5@lixiang.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants