Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: keep image tar file name consistent with image name #287

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 29, 2021

Ⅰ. Describe what this PR does

bugfix: keep image tar file name consistent with image name.

For example, the image openyurt/yurtctl-servant:v0.3.0-amd64 should be saved as yurtctl-servant-linux-amd64.tar instead of yurtctl-linux-amd64.tar.

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

make release

Ⅴ. Special notes for reviews

@SataQiu
Copy link
Member Author

SataQiu commented Apr 29, 2021

/cc @rambohe-ch @Fei-Guo

Copy link
Member

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@Fei-Guo Fei-Guo merged commit 267643e into openyurtio:master Apr 29, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants