Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove yurt-app-manager from the build targets #282

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 27, 2021

Ⅰ. Describe what this PR does

Since we have migrated yurt-app-manager to a independent repository, make release will now produce the following error:

can't load package: package /opt/src/cmd/yurt-app-manager: cannot find package
make: *** [release] Error 1

This PR removes yurt-app-manager from the build targets to fix this bug.

Ref: #280

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

make release

Ⅴ. Special notes for reviews

Signed-off-by: SataQiu <1527062125@qq.com>
@SataQiu
Copy link
Member Author

SataQiu commented Apr 27, 2021

/cc @rambohe-ch @Fei-Guo

@charleszheng44 charleszheng44 self-requested a review April 27, 2021 04:38
@charleszheng44 charleszheng44 merged commit f4825eb into openyurtio:master Apr 27, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants