Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bird2: add test.sh for bird #1064

Merged
merged 1 commit into from
May 28, 2024
Merged

bird2: add test.sh for bird #1064

merged 1 commit into from
May 28, 2024

Conversation

bradfordzhang
Copy link
Contributor

Maintainer: @tohojo
Compile tested: x86_64 generic
Run tested: x86_64 generic test done

Description: add test.sh for bird2

@BKPepe
Copy link
Member

BKPepe commented May 26, 2024

CI fails:

Testing package bird2 in version  from bird2
No pre-test.sh script available
Installing bird2 (2.15.1-r1) to root...
Failed to connect to ubus
Configuring bird2.
Use package specific test.sh
BIRD version 2.15.1
Test failed

@bradfordzhang
Copy link
Contributor Author

CI fails:

Testing package bird2 in version  from bird2
No pre-test.sh script available
Installing bird2 (2.15.1-r1) to root...
Failed to connect to ubus
Configuring bird2.
Use package specific test.sh
BIRD version 2.15.1
Test failed

Need to add 2>&1 to redirect stderr to stdout

Signed-off-by: Bradford Zhang <zyc@zyc.name>
@bradfordzhang
Copy link
Contributor Author

bradfordzhang commented May 26, 2024

CI fails:

Testing package bird2 in version  from bird2
No pre-test.sh script available
Installing bird2 (2.15.1-r1) to root...
Failed to connect to ubus
Configuring bird2.
Use package specific test.sh
BIRD version 2.15.1
Test failed

It should be fixed now, thanks for your waiting~ :D
So do #1065

@tohojo
Copy link
Contributor

tohojo commented May 26, 2024

What's the purpose of having this? Does is catch any actual errors?

@bradfordzhang
Copy link
Contributor Author

What's the purpose of having this? Does is catch any actual errors?

Just to test if bird is installed correctly.

@tohojo
Copy link
Contributor

tohojo commented May 27, 2024 via email

@bradfordzhang
Copy link
Contributor Author

Bradford Zhang @.***> writes:

What's the purpose of having this? Does is catch any actual errors?

Just to test if bird is installed correctly.

But why is such a test useful? Did you run into any particular issue
where this test helps/would have helped? :)

In #1052 @BKPepe mentioned there is no test script for this package in CI, so this script just to make sure bird2 is installed correctly and can run without any error in dependency.

@tohojo
Copy link
Contributor

tohojo commented May 27, 2024

Alright, makes sense. But please bump the package revision along with the change :)

@bradfordzhang
Copy link
Contributor Author

Alright, makes sense. But please bump the package revision along with the change :)

The version is bumped in previous commits

@tohojo
Copy link
Contributor

tohojo commented May 27, 2024

Sure, but that's a week ago. PKG_RELEASE should be bumped along with this change or there will be two different packages with no indication of the change...

@bradfordzhang
Copy link
Contributor Author

bradfordzhang commented May 27, 2024

Sure, but that's a week ago. PKG_RELEASE should be bumped along with this change or there will be two different packages with no indication of the change...

Got it, so i need to edit PKG_RELEASE to 2? :D

@BKPepe
Copy link
Member

BKPepe commented May 27, 2024

Sure, but that's a week ago. PKG_RELEASE should be bumped along with this change or there will be two different packages with no indication of the change...

This file is not included in the package itself, it it just in this repository to be sure that bird does not segfault immediately or that it runs.

@BKPepe BKPepe merged commit 7b87526 into openwrt:master May 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants