Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faad2: Remove BUILD_PATENTED #5766

Merged
merged 1 commit into from
Mar 22, 2018
Merged

faad2: Remove BUILD_PATENTED #5766

merged 1 commit into from
Mar 22, 2018

Conversation

thess
Copy link
Member

@thess thess commented Mar 15, 2018

Maintainer: me
Compile tested: ar71xx, OpenWrt trunk
Run tested: N/A

Description:
FAAD2 is freely available for non-commercial use.
Permits building of pianod and squeezelite in buildbot configs.

Signed-off-by: Ted Hess thess@kitschensync.net

Signed-off-by: Ted Hess <thess@kitschensync.net>
@neheb
Copy link
Contributor

neheb commented Mar 15, 2018

I have no comment on the buildbot.

Isn't the purpose of BUILD_PATENTED for commercial use?

@thess
Copy link
Member Author

thess commented Mar 15, 2018

Maybe - depends on the LICENSE and/or any relevant patents.

Ever since we turned off BUILD_PATENTED in the default configs, there were too many packages no longer building which may not have been the intent or were not really "patented" anyway.

@neheb
Copy link
Contributor

neheb commented Mar 15, 2018

In Fedora (under the guidance of Red Hat's legal team), a modified version of fdk-aac is allowed to be redistributed. Modified to remove HE and HEv2 as those are problematic.

I'm not sure what OpenWrt wants to do here. One choice would be to add fdk-aac with Fedora's changes and patch the packages to use that. Time consuming.

Could also try defining BUILD_PATENTED for the buildbot.

@thess thess merged commit cf84f78 into openwrt:master Mar 22, 2018
@thess thess deleted the faad2-config branch May 22, 2018 18:16
dangowrt added a commit that referenced this pull request Oct 13, 2022
 Noteworthy changes in version 1.17.0 (2022-02-07)
 -------------------------------------------------

 * New context flag "key-origin".  [#5733]
 * New context flag "import-filter".  [#5739]
 * New export mode to export secret subkeys.  [#5757]
 * Detect errors during the export of secret keys.  [#5766]
 * New function gpgme_op_receive_keys to import keys from a keyserver
   without first running a key listing.  [#5808]
 * Detect bad passphrase error in certificate import.  [T5713]
 * Allow setting --key-origin when importing keys.  [T5733]
 * Support components "keyboxd", "gpg-agent", "scdaemon", "dirmngr",
   "pinentry", and "socketdir" in gpgme_get_dirinfo.  [T5727,T5613]
 * Under Unix use poll(2) instead of select(2), when available.
   [T2385]
 * Do not use --flat_namespace when linking for macOS.  [T5610]
 * Fix results returned by gpgme_data_* functions.  [T5481]
 * Support closefrom also for glibc.  [rM4b64774b6d]
 * cpp,qt: Add support for export of secret keys and secret subkeys.
   [#5757]
 * cpp,qt: Support for adding existing subkeys to other keys.  [#5770]
 * qt: Extend ChangeExpiryJob to change expiration of primary key
   and of subkeys at the same time. [#4717]
 * qt: Expect UTF-8 on stderr on Windows.  [rM8fe1546282]
 * qt: Allow retrieving the default value of a config entry.  [T5515]

 Noteworthy changes in version 1.17.1 (2022-03-06)
 -------------------------------------------------

 * qt: Fix a bug in the ABI compatibility of 1.17.0.  [T5834]

 Noteworthy changes in version 1.18.0 (2022-08-10)
 -------------------------------------------------

 * New keylist mode to force refresh via external methods.  [T5951]
 * The keylist operations now create an import result to report the
   result of the locate keylist modes.  [T5951]
 * core: Return BAD_PASSPHRASE error code on symmetric decryption
   failure.  [T5939]
 * cpp, qt: Do not export internal symbols anymore.  [T5906]
 * cpp, qt: Support revocation of own OpenPGP keys.  [T5904]
 * qt: The file name of (signed and) encrypted data can now be set.  [T6056]
 * cpp, qt: Support setting the primary user ID.  [T5938]
 * python: Fix segv(NULL) when inspecting contect after exeception.  [T6060]

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
(cherry picked from commit d779959)
(cherry picked from commit 00bfb4f)
roaldclark pushed a commit to qculug/openwrt-packages that referenced this pull request Nov 21, 2022
 Noteworthy changes in version 1.17.0 (2022-02-07)
 -------------------------------------------------

 * New context flag "key-origin".  [openwrt#5733]
 * New context flag "import-filter".  [openwrt#5739]
 * New export mode to export secret subkeys.  [openwrt#5757]
 * Detect errors during the export of secret keys.  [openwrt#5766]
 * New function gpgme_op_receive_keys to import keys from a keyserver
   without first running a key listing.  [openwrt#5808]
 * Detect bad passphrase error in certificate import.  [T5713]
 * Allow setting --key-origin when importing keys.  [T5733]
 * Support components "keyboxd", "gpg-agent", "scdaemon", "dirmngr",
   "pinentry", and "socketdir" in gpgme_get_dirinfo.  [T5727,T5613]
 * Under Unix use poll(2) instead of select(2), when available.
   [T2385]
 * Do not use --flat_namespace when linking for macOS.  [T5610]
 * Fix results returned by gpgme_data_* functions.  [T5481]
 * Support closefrom also for glibc.  [rM4b64774b6d]
 * cpp,qt: Add support for export of secret keys and secret subkeys.
   [openwrt#5757]
 * cpp,qt: Support for adding existing subkeys to other keys.  [openwrt#5770]
 * qt: Extend ChangeExpiryJob to change expiration of primary key
   and of subkeys at the same time. [openwrt#4717]
 * qt: Expect UTF-8 on stderr on Windows.  [rM8fe1546282]
 * qt: Allow retrieving the default value of a config entry.  [T5515]

 Noteworthy changes in version 1.17.1 (2022-03-06)
 -------------------------------------------------

 * qt: Fix a bug in the ABI compatibility of 1.17.0.  [T5834]

 Noteworthy changes in version 1.18.0 (2022-08-10)
 -------------------------------------------------

 * New keylist mode to force refresh via external methods.  [T5951]
 * The keylist operations now create an import result to report the
   result of the locate keylist modes.  [T5951]
 * core: Return BAD_PASSPHRASE error code on symmetric decryption
   failure.  [T5939]
 * cpp, qt: Do not export internal symbols anymore.  [T5906]
 * cpp, qt: Support revocation of own OpenPGP keys.  [T5904]
 * qt: The file name of (signed and) encrypted data can now be set.  [T6056]
 * cpp, qt: Support setting the primary user ID.  [T5938]
 * python: Fix segv(NULL) when inspecting contect after exeception.  [T6060]

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
(cherry picked from commit d779959)
(cherry picked from commit 00bfb4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants