Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: bump to 8.10.0 #5734

Merged
merged 1 commit into from
Mar 10, 2018
Merged

node: bump to 8.10.0 #5734

merged 1 commit into from
Mar 10, 2018

Conversation

ratkaj
Copy link
Contributor

@ratkaj ratkaj commented Mar 9, 2018

Maintainer: John Crispin @blogic , Adrian Panella @ianchi
Compile tested: mvebu, OpenWrt master
Run tested: mvebu,OpenWrt master, Linksys wrt1200

Description:
Version bump to 8.10.0
Refreshed patches
Added npx install
Added 004-node_crypto-remove-std.patch

Additional patch fixes node_cypto compile failure:
./src/node_crypto.cc:5626:32: error: expected unqualified-id before '('

Signed-off-by: Arturo Rinaldi arty.net2@gmail.com
Signed-off-by: Marko Ratkaj marko.ratkaj@sartura.hr

Changes:
Version bump to 8.10.0
Refreshed patches
Added npx install
Added 004-node_crypto-remove-std.patch

Additional patch fixes node_cypto compile failure:
./src/node_crypto.cc:5626:32: error: expected unqualified-id before '('

Signed-off-by: Arturo Rinaldi <arty.net2@gmail.com>
Signed-off-by: Marko Ratkaj <marko.ratkaj@sartura.hr>
@nxhack
Copy link
Contributor

nxhack commented Mar 26, 2018

@ratkaj

The host build fails due to the gcc situation of host.

nodejs/node#19196

@ratkaj
Copy link
Contributor Author

ratkaj commented Mar 26, 2018

@nxhack i can confirm the issue, though i was only able to reproduce on a Ubuntu machine.
It builds fine on our Arch machines so it slipped. Probably due to gcc/glibc versions as it fails on host-compile. I'm in a bit of a pickle but i will try to push a fix today or tomorrow.

@nxhack nxhack mentioned this pull request May 7, 2018
@lpaulic lpaulic deleted the node_bump_to_8.10.0 branch April 9, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants