Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-softether: add basic softether status page #4665

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

berenyibalazs
Copy link

This adds a basic SoftEther VPN client status page.
I have tested/using it on 19.07.4 mir3g.

Copy link
Member

@feckert feckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to tabs.
Missing new line for luci-app-softether.json

@berenyibalazs
Copy link
Author

berenyibalazs commented Dec 17, 2020

Hi @feckert,

thanks for the comments! Currently I made it similar to the WireGuard status page.

What do you mean? Like on admin/system/system the tabs for Genereal/Time/Logging?
For each VPN connection(account)?

Or i can add more info tabs as there is some "versionget and "check" commands.
So there would be tabs like: Version, Accouts, Nics, Troubleshoot.

BR,
Balazs.

@feckert feckert changed the title Softether status page luci-app-softether: add basic softether status page Dec 17, 2020
@berenyibalazs
Copy link
Author

Hi @feckert
hope i fixed everything.
Thanks, Balazs.

luci-admin-status-softether

@berenyibalazs
Copy link
Author

@feckert Is it possible to merge this PR to 19.07 branch?
Then i will make a javascript based one for master. On the other hand do javascript based ones working on 19.07?

@berenyibalazs berenyibalazs force-pushed the softether branch 3 times, most recently from cfa6688 to 57a262a Compare January 10, 2021 19:15
@berenyibalazs
Copy link
Author

Managed to modernize to Javascript.

Signed-off-by: BERENYI Balazs <balazs@wee.hu>
Copy link
Member

@feckert feckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use softether, but the source looks good so far.

@feckert feckert merged commit 60c27aa into openwrt:master Jan 13, 2021
@feckert
Copy link
Member

feckert commented Jan 13, 2021

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants