Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better crawling experience #696

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Better crawling experience #696

merged 3 commits into from
Jun 25, 2020

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Jun 25, 2020

Removed noisy errors and deprecation warnings.
Closes #672

@codecov
Copy link

codecov bot commented Jun 25, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@43922bc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #696   +/-   ##
=========================================
  Coverage          ?   58.80%           
=========================================
  Files             ?       44           
  Lines             ?     4071           
  Branches          ?        0           
=========================================
  Hits              ?     2394           
  Misses            ?     1677           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43922bc...5928989. Read the comment docs.

@vringar vringar requested review from birdsarah and englehardt June 25, 2020 15:32
birdsarah
birdsarah approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@birdsarah birdsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@englehardt englehardt merged commit 7c678d6 into master Jun 25, 2020
@englehardt englehardt deleted the better_crawling branch August 3, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@englehardt englehardt englehardt approved these changes

@birdsarah birdsarah birdsarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing "visit with visit_id xxx was interrupted error"
3 participants
@vringar @birdsarah @englehardt