-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom image during loading of the geppetto application #171
Conversation
@Robbie1977 could you review the changes in the stackviewer please? @gidili could you review the geppetto.ejs and if Robbie is fine with the stackviewer changes merge this please? Thx! |
address this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddelpiano my only concerns in the code are about the Stackviewer stuff and the weird styling of the image.
Also I can't see the related issue in the PR nor in the geppetto-client project. Every pr should refer to the issue in the title and a command in the body (e.g. "Closes #500")
This is just an extension of Jesus' branch but based on the latest development, so I opened a new branch from my local development.