Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom image during loading of the geppetto application #171

Merged
merged 6 commits into from
Jan 22, 2020

Conversation

ddelpiano
Copy link
Contributor

  • Custom image can be placed in the webapp/images/splash.png
  • the custom image will replace the text "LOADING... [~3MB]" and displayed instead of it during the load.

This is just an extension of Jesus' branch but based on the latest development, so I opened a new branch from my local development.

@ddelpiano ddelpiano added the enhancement New feature or request label Jan 15, 2020
@ddelpiano ddelpiano self-assigned this Jan 15, 2020
@ddelpiano ddelpiano requested a review from gidili January 15, 2020 13:09
@ddelpiano
Copy link
Contributor Author

@Robbie1977 could you review the changes in the stackviewer please?
I had some conflict and resolved them but a second look will make me feel in peace, thx.

@gidili could you review the geppetto.ejs and if Robbie is fine with the stackviewer changes merge this please? Thx!

@ddelpiano
Copy link
Contributor Author

address this

@tarelli tarelli requested a review from filippomc January 15, 2020 13:29
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddelpiano my only concerns in the code are about the Stackviewer stuff and the weird styling of the image.

Also I can't see the related issue in the PR nor in the geppetto-client project. Every pr should refer to the issue in the title and a command in the body (e.g. "Closes #500")

js/components/widgets/stackViewer/StackViewerComponent.js Outdated Show resolved Hide resolved
js/pages/geppetto/geppetto.ejs Outdated Show resolved Hide resolved
@gidili gidili merged commit 976e1bf into development Jan 22, 2020
@filippomc filippomc deleted the feature/467_2 branch June 26, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants