Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/124 #125

Merged
merged 10 commits into from
Jan 10, 2020
Merged

Feature/124 #125

merged 10 commits into from
Jan 10, 2020

Conversation

Robbie1977
Copy link
Contributor

@Robbie1977 Robbie1977 commented Nov 8, 2019

  • [another ticket] Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

Adding float over labelling to StackViewer #124

Adding the float over-identification following the mouse pointer

@Robbie1977 Robbie1977 requested a review from ddelpiano November 8, 2019 17:00
@Robbie1977
Copy link
Contributor Author

https://github.com/openworm/geppetto-client/pull/125/files#diff-0a1e5757b508f99c409aaeb43755226aL446-R472
Is simply removing the check to see if the mouse has moved since the request was made which is no longer needed as the label is placed by the coordinates of the original request.

@Robbie1977
Copy link
Contributor Author

https://github.com/openworm/geppetto-client/pull/125/files#diff-0a1e5757b508f99c409aaeb43755226aR893-R902
Status Text appears on the top left as before but hover-over identification is placed to the bottom right of the cursor.

@Robbie1977
Copy link
Contributor Author

Robbie1977 commented Nov 8, 2019

resolves VirtualFlyBrain/geppetto-vfb#198

@Robbie1977
Copy link
Contributor Author

resolves VirtualFlyBrain/VFB2#110

@Robbie1977
Copy link
Contributor Author

resolves VirtualFlyBrain/VFB2#71

@Robbie1977
Copy link
Contributor Author

resolves VirtualFlyBrain/VFB2#70

@Robbie1977 Robbie1977 requested a review from tarelli November 8, 2019 17:16
@Robbie1977
Copy link
Contributor Author

resolves #124

Copy link
Contributor

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robbie1977 @tarelli I am currently testing this from vfb_geppetto_application (as robb suggested since this is the latest deployed and the label issue is resolved).
@Robbie1977 I can see some differences between this and vfb_geppetto_application, can we re-align this with vfb_geppetto_application (where I can see the labels working) so we can approve the merge? (if you are busy let me know and I can do this).
Thx!

@Robbie1977
Copy link
Contributor Author

@ddelpiano @tarelli This is ready to go now.

@Robbie1977 Robbie1977 requested a review from ddelpiano December 5, 2019 15:15
@Robbie1977
Copy link
Contributor Author

@tarelli @ddelpiano Can we get this one merged?

@tarelli tarelli merged commit 3faf3b8 into development Jan 10, 2020
@tarelli
Copy link
Member

tarelli commented Jan 10, 2020

@Robbie1977 done, still hadn't had a chance to catch up with all PRs!

@filippomc filippomc deleted the feature/124 branch June 26, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants