Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/110 Uses properties in GeppettoConfiguration.json (if present) #111

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

jrmartin
Copy link
Contributor

  • Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

Copy link
Contributor

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrmartin overall very good and looks exactly what we need, just requested 2 tiny changes to keep the component in line with geppetto's current behaviour and to explain a little bit the getProperty function in order to be easier for other, when reading the code in a second moment, to understand what happens there.
Good job, thanks!

js/components/controls/modals/ErrorModal.js Outdated Show resolved Hide resolved
js/components/controls/modals/ErrorModal.js Outdated Show resolved Hide resolved
js/components/controls/modals/ErrorModal.js Outdated Show resolved Hide resolved
@ddelpiano ddelpiano requested a review from gidili October 21, 2019 12:14
@jrmartin
Copy link
Contributor Author

@ddelpiano I committed those changes (error modal button visible by default and more readable getProperty function)

@gidili gidili merged commit 0bd0683 into development Oct 21, 2019
@ddelpiano
Copy link
Contributor

@Robbie1977 this is the pr for the error modal link that redirect to openworm, fixed now.

@filippomc filippomc changed the title Uses properties in GeppettoConfiguration.json (if present) feature/110 Uses properties in GeppettoConfiguration.json (if present) Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants