Skip to content
This repository has been archived by the owner on Jul 9, 2020. It is now read-only.

Fix #31: Make the hint text bolder. #32

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

rohithasrk
Copy link
Contributor

This PR makes the hint-text "Choose items and order by drag & drop." bolder by changing add a little css to the admin.css file.

@rohithasrk
Copy link
Contributor Author

@nemesisdesign : Please review.

@coveralls
Copy link

coveralls commented Mar 3, 2017

Coverage Status

Coverage remained the same at 99.877% when pulling 425f497 on rohithasrk:hint-text-bold into c368144 on openwisp:master.

@@ -96,3 +96,7 @@
#container .help a,
#netjsonconfig-hint a{ text-decoration: underline }
#netjsonconfig-hint{ width: auto }

p.help{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just wanted the text "Choose items and order by drag & drop" to be bold, not every help text.

Also, making it bolder would probably not be enough to make it more evident, we should make it darker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I understand. So, maybe changing the color of the text to black? This should do it right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, use #333 as it's also used elsewhere in the default django-admin style.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashed and re pushed the commits. Please check

@coveralls
Copy link

coveralls commented Mar 3, 2017

Coverage Status

Coverage remained the same at 99.877% when pulling f2d820d on rohithasrk:hint-text-bold into c368144 on openwisp:master.

@nemesifier nemesifier merged commit e547aac into openwisp:master Mar 3, 2017
@rohithasrk rohithasrk deleted the hint-text-bold branch March 4, 2017 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants