Skip to content
This repository has been archived by the owner on Jul 9, 2020. It is now read-only.

[config-editor] VPN servers JSON-schema validation fails #55

Closed
nemesifier opened this issue May 4, 2017 · 10 comments
Closed

[config-editor] VPN servers JSON-schema validation fails #55

nemesifier opened this issue May 4, 2017 · 10 comments
Labels

Comments

@nemesifier
Copy link
Member

How to reproduce:

  • go to VPN servers
  • add new
  • fill in the minimum required information, click save and continue
  • now try to go into advanced mode, notice the validation failures, even though the entered JSON is considered valid by other json validation libraries
@gastonche
Copy link
Contributor

working on this now

@nemesifier
Copy link
Member Author

Great, keep us up to date 👍

@nemesifier nemesifier added the bug label May 10, 2017
@nemesifier
Copy link
Member Author

@gastonche have you been able to reproduce the issue?

I thought that it happens because the validation library used by the json-schema editor and the advanced mode editor is different. The one used by json-schema editor works correctly.

@gastonche
Copy link
Contributor

gastonche commented May 10, 2017 via email

@nemesifier
Copy link
Member Author

@gastonche if we could configure the advanced editor to use the same JSON-schema validation mechanism of the JSON-Schema UI generator it would be perfect

@gastonche
Copy link
Contributor

gastonche commented May 10, 2017 via email

@nemesifier
Copy link
Member Author

@gastonche any update on this?

@gastonche
Copy link
Contributor

gastonche commented May 18, 2017 via email

@nemesifier
Copy link
Member Author

@gastonche Add a way to easily disable the schema validation. I will disable this feature in the VPN management form.

@gastonche
Copy link
Contributor

gastonche commented May 19, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants