Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more HTML attribute reflection names #997

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 20, 2023

Currently the collector marks quite a few HTML attributes as unsupported. This is due to different names in the DOM reflection. The JSON already included quite a few for char, charoff, valign and bgcolor, but some were still missing. This PR fixes that.

Needed for openwebdocs/project#160

@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-997 December 20, 2023 17:36 Inactive
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I've not checked completion, but these are ok!)

@teoli2003 teoli2003 merged commit c08c004 into main Dec 20, 2023
5 checks passed
@Elchi3 Elchi3 deleted the html-element-reflection branch December 20, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants