fix: code issues and nits

lib/exporter.ts

@@ -34,7 +34,7 @@ const getReportMeta = (report: Report): ReportMeta => {
     .createHash("sha1")
     .update(buffer)
     .digest("hex")
-    .substr(0, 10);
+    .substring(0, 10);
 
   // Get user agent details
   const ua = parseUA(report.userAgent, bcdBrowsers);

lib/storage.ts

@@ -152,7 +152,7 @@ class CloudStorage extends Storage {
     await Promise.all(
       files.map(async (file) => {
         assert(file.name.startsWith(prefix));
-        const key = decodeURIComponent(file.name.substr(prefix.length));
+        const key = decodeURIComponent(file.name.substring(prefix.length));
         const data = (await file.download())[0];
         result[key] = JSON.parse(data.toString());
       }),

prepare.ts

@@ -40,5 +40,5 @@ const prepare = async () => {
 };
 
 if (esMain(import.meta)) {
-  prepare();
+  await prepare();
 }

scripts/find-missing-features.ts

@@ -55,7 +55,7 @@ const traverseFeatures = (
             if (statement.prefix) {
               let name = id;
               if (path.startsWith("api.")) {
-                name = name[0].toUpperCase() + name.substr(1);
+                name = name[0].toUpperCase() + name.substring(1);
               }
               aliases.add(statement.prefix + name);
             }

scripts/selenium.ts

@@ -659,8 +659,8 @@
     if (!ctx.testenv) {
       const filename = path.basename(new URL(downloadUrl).pathname);
       log(task, `Downloading ${filename} ...`);
-      const report = await (await fetch(downloadUrl)).buffer();
+      const report = await (await fetch(downloadUrl)).arrayBuffer();
       await fs.writeFile(path.join(RESULTS_DIR, filename), report);
     }
   } finally {
     driver.quit().catch(() => {});

static/resources/harness.js

@@ -1750,7 +1750,6 @@
               serviceWorker.removeEventListener("statechange", stateListener);
 
               reject(new Error("Installing service worker became redundant"));
-              return;
             }
           }
 

test-builder/javascript.ts

@@ -230,7 +230,7 @@ const buildTest = async (
     let property = parts[parts.length - 1];
 
     if (property.startsWith("@@")) {
-      property = `Symbol.${property.substr(2)}`;
+      property = `Symbol.${property.substring(2)}`;
     }
 
     const owner =

views/extensioncheck.ejs

@@ -34,7 +34,7 @@ See the LICENSE file for copyright details
           }
         }
       };
-    };
+    }
 
     function checkChromeExtension(id, callback) {
       if (id) {
@@ -80,7 +80,7 @@ See the LICENSE file for copyright details
           });
         }
       })
-    };
+    }
 
     function renderNote(extension) {
       var el = document.createElement('div');
@@ -133,7 +133,7 @@ See the LICENSE file for copyright details
           }
         });
       });
-    };
+    }
 
     checkExtensions(<%- JSON.stringify(browserExtensions) %>);
   })();

views/index.ejs

@@ -88,9 +88,7 @@ See the LICENSE file for copyright details
 
 <script>
   function main() {
-    var form = document.getElementById('test-form');
     var testSelection = document.getElementById('test-selection');
-    var limitExposure = document.getElementById('limit-exposure');
     var limitExposureBox = document.getElementById('limit-exposure-box');
 
     testSelection.onchange = function() {

views/layout.ejs

@@ -43,7 +43,7 @@ See the LICENSE file for copyright details
       <a href="/"><span class="mdi mdi-home"> Home</span></a>
       <a href="/docs/about.md"><span class="mdi mdi-information"> About</span></a>
       <a href="/docs"><span class="mdi mdi-file-document-multiple"> Docs</span></a>
-      <a href="https://opencollective.com/open-web-docs"><span class="mdi mdi-hand-coin"></span> Donate</title>
+      <a href="https://opencollective.com/open-web-docs"><span class="mdi mdi-hand-coin"></span> Donate</a>
       <a href="https://github.com/openwebdocs/mdn-bcd-collector"><span class="mdi mdi-github"> GitHub</span></a>
       <a href="/changelog">v<%- appVersion %></a>
     </nav>

views/tests.ejs

@@ -53,18 +53,18 @@ See the LICENSE file for copyright details
       default:
         throw new Error(`Tried to load an unknown instance type of ${resource.type}!`)
     }
-  }; %>
+  } %>
 </div>
 
 <script src="/resources/harness.js"></script>
 
 <script>
   <% for (const [instanceId, instance] of Object.entries(resources)
-    .filter((item) => (item[1].type === 'instance'))) { 
+    .filter((item) => (item[1].type === 'instance'))) {
     if (resourcesToLoad.has(instanceId)) { %>
       bcd.addInstance("<%- instanceId %>", <%- JSON.stringify(instance.src) %>, {callback: <%- !!instance.callback %>});
     <% }
-   }; %>
+   } %>
   <% tests.forEach(function(test) { %>
     bcd.addTest("<%- test.ident %>", <%- JSON.stringify(test.tests) %>, "<%- test.exposure %>");
   <% }); %>