-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update constructor judgments of LLRT #1472
feat: Update constructor judgments of LLRT #1472
Conversation
Hi @queengooborg . Is the signed Commit working? |
f9b2382
to
1a4ece3
Compare
1a4ece3
to
5266514
Compare
Hey @nabetti1720, looks like it didn't work unfortunately. If it is verified you would see "verified" with the commit. See for example https://github.com/openwebdocs/mdn-bcd-collector/pull/1487/commits. |
Thanks for the confirmation. |
Ah interesting, I see this is being talked about in the docs: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#signature-verification-for-rebase-and-merge. GitHub recommends to "rebase and merge locally, and then push the changes to the pull request's base branch." |
5266514
to
56ca5f5
Compare
Hi @Elchi3 , Thanks for the information. I have force pushed the local content again. Do I need to rebase from this state? If you can confirm that my commit is verified, can you rebase and merge it on the maintainer's side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nabetti1720, this looks good to me. 👍
Congratulations on your first merged pull request in this project! 🎉
In LLRT, this corresponds to the following message that occurs in the execution of the constructor of an object that requires one or more arguments.
See also. unjs/runtime-compat#126
Execution results in LLRT (cli mode):