-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation and flowchart for update script refactor #1076
Adds documentation and flowchart for update script refactor #1076
Conversation
Thanks @ChrisC! I'll give a proper review later, but I think it would be nice to have the flowchart defined in Mermaid syntax, which GitHub natively supports, making it easier to modify the flowchart in the future if need be. Would you be down to make that change? |
Appreciate the mermaid syntax suggestion @queengooborg ! Will look into it and implement the flowchart that way 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits!
Hey @ChrisC, just checking in to see if you plan on returning to this PR! |
I'm hoping to! Wasn't able to make the time for it the last few weeks, but hopefully can return to this in early March! Thanks for checking in 👍🏽 |
Sounds good! If you'd like, I'd be happy to tackle the requested changes and Mermaid conversion? |
Yes if you have the bandwidth to tackle sooner, feel free to jump on it! 😄 |
Awesome! In that case, would you mind enabling maintainer editing permissions for this PR, if you're able to? That way, I can push to this PR! |
Yes, let me just confirm that we can do that! |
Ok @queengooborg you should have editing permissions now! Thanks again for offering to help close this out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Let's get this landed!
Adding some additional documentation and a flowchart for the recent refactor for the
update-bcd
script that were made for @foolip while the changes were being reviewed. @foolip made the suggestion that this additional documentation may be useful to other maintainers and could possibly be added to the repo as well, so offering it here!cc @mzgoddard