Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation and flowchart for update script refactor #1076

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

ChrisC
Copy link
Contributor

@ChrisC ChrisC commented Jan 16, 2024

Adding some additional documentation and a flowchart for the recent refactor for the update-bcd script that were made for @foolip while the changes were being reviewed. @foolip made the suggestion that this additional documentation may be useful to other maintainers and could possibly be added to the repo as well, so offering it here!

cc @mzgoddard

@queengooborg
Copy link
Member

Thanks @ChrisC! I'll give a proper review later, but I think it would be nice to have the flowchart defined in Mermaid syntax, which GitHub natively supports, making it easier to modify the flowchart in the future if need be. Would you be down to make that change?

@ChrisC
Copy link
Contributor Author

ChrisC commented Jan 22, 2024

Thanks @ChrisC! I'll give a proper review later, but I think it would be nice to have the flowchart defined in Mermaid syntax, which GitHub natively supports, making it easier to modify the flowchart in the future if need be. Would you be down to make that change?

Appreciate the mermaid syntax suggestion @queengooborg ! Will look into it and implement the flowchart that way 👍🏽

Copy link
Member

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits!

docs/update-bcd-data-flow.md Outdated Show resolved Hide resolved
docs/update-bcd-data-flow.md Outdated Show resolved Hide resolved
docs/update-bcd-data-flow.md Outdated Show resolved Hide resolved
docs/update-bcd-data-flow.md Outdated Show resolved Hide resolved
@queengooborg
Copy link
Member

Hey @ChrisC, just checking in to see if you plan on returning to this PR!

@ChrisC
Copy link
Contributor Author

ChrisC commented Feb 20, 2024

Hey @ChrisC, just checking in to see if you plan on returning to this PR!

I'm hoping to! Wasn't able to make the time for it the last few weeks, but hopefully can return to this in early March! Thanks for checking in 👍🏽

@queengooborg
Copy link
Member

Sounds good! If you'd like, I'd be happy to tackle the requested changes and Mermaid conversion?

@ChrisC
Copy link
Contributor Author

ChrisC commented Feb 20, 2024

Yes if you have the bandwidth to tackle sooner, feel free to jump on it! 😄

@queengooborg
Copy link
Member

Awesome! In that case, would you mind enabling maintainer editing permissions for this PR, if you're able to? That way, I can push to this PR!

@ChrisC
Copy link
Contributor Author

ChrisC commented Feb 20, 2024

Awesome! In that case, would you mind enabling maintainer editing permissions for this PR, if you're able to? That way, I can push to this PR!

Yes, let me just confirm that we can do that!

@ChrisC
Copy link
Contributor Author

ChrisC commented Feb 20, 2024

Ok @queengooborg you should have editing permissions now! Thanks again for offering to help close this out!

@queengooborg queengooborg dismissed their stale review February 21, 2024 03:55

Changes have been applied

Copy link
Member

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's get this landed!

@queengooborg queengooborg merged commit cda2aad into openwebdocs:main Feb 22, 2024
2 checks passed
@queengooborg queengooborg deleted the update-refactor-docs-v2 branch February 22, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants