-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify which task elements and workflows are singular and which can be specified multiple times. #594
Labels
K-clarification
(Kind) Clarifications regarding the WDL specification.
Z-specification-change
(Metadata) An issue or PR related to a specification change.
Milestone
Comments
1 task
claymcleod
added a commit
to claymcleod/wdl
that referenced
this issue
Dec 12, 2023
Previously, the number of sections within `task` and `workflow` blocks was implied rather than explicit. This commit introduces clear, concise language describing the number of sections allowed and whether each section is required/optional. Furhter, some housekeeping items were included to make the editted text more consistent. Closes openwdl#594
claymcleod
added a commit
to claymcleod/wdl
that referenced
this issue
Dec 12, 2023
Previously, the number of sections within `task` and `workflow` blocks was implied rather than explicit. This commit introduces clear, concise language describing the number of sections allowed and whether each section is required/optional. Furhter, some housekeeping items were included to make the editted text more consistent. Closes openwdl#594
claymcleod
added a commit
to claymcleod/wdl
that referenced
this issue
Dec 12, 2023
Previously, the number of sections within `task` and `workflow` blocks was implied rather than explicit. This commit introduces clear, concise language describing the number of sections allowed and whether each section is required/optional. Furhter, some housekeeping items were included to make the editted text more consistent. Closes openwdl#594
claymcleod
added a commit
to claymcleod/wdl
that referenced
this issue
Dec 12, 2023
Previously, the number of sections within `task` and `workflow` blocks was implied rather than explicit. This commit introduces clear, concise language describing the number of sections allowed and whether each section is required/optional. Furhter, some housekeeping items were included to make the editted text more consistent. Closes openwdl#594
claymcleod
added a commit
to claymcleod/wdl
that referenced
this issue
Dec 12, 2023
Previously, the number of sections within `task` and `workflow` blocks was implied rather than explicit. This commit introduces clear, concise language describing the number of sections allowed and whether each section is required/optional. Furhter, some housekeeping items were included to make the editted text more consistent. Closes openwdl#594
@claymcleod this is a general limitation of the grammars/parsers. We did not want to enforce strict ordering of task/workflow elements which would be required to use the grammar to enforce a single occurrence
|
Agree with Patrick - this is true at least for the ANTLR parser. But I support adding clarification to the spec. |
claymcleod
added a commit
to claymcleod/wdl
that referenced
this issue
Mar 23, 2024
Previously, the number of sections within `task` and `workflow` blocks was implied rather than explicit. This commit introduces clear, concise language describing the number of sections allowed and whether each section is required/optional. Furhter, some housekeeping items were included to make the editted text more consistent. Closes openwdl#594
claymcleod
added a commit
to claymcleod/wdl
that referenced
this issue
Mar 23, 2024
Previously, the number of sections within `task` and `workflow` blocks was implied rather than explicit. This commit introduces clear, concise language describing the number of sections allowed and whether each section is required/optional. Furhter, some housekeeping items were included to make the editted text more consistent. Also included in this commit (these changes were squashed): * revise: adds suggested ordering to elements This is based on @geoffjentry's suggestions on openwdl#598. * revise: adds `requirements` and `hints`, removes ordering recommendations Closes openwdl#594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
K-clarification
(Kind) Clarifications regarding the WDL specification.
Z-specification-change
(Metadata) An issue or PR related to a specification change.
There a quite few workflow and task elements that the specification appears to imply can only occur once but that the grammar allows multiple occurrences.
For example, take a look at the task elements:
For what it's worth, every example I have seen appears to follow the above conventions.
Contrast that with the parser implementation, which I interpret as (paraphrasing): a task can contain one or more task elements. A task element is defined as a
task_input
section, atask_output
section, atask_command
section, atask_runtime
section, abound_decls
section, aparameter_meta
section, or ameta
section. As such, it follows that these elements can be defined multiple times.The text was updated successfully, but these errors were encountered: