fix: expose oob domain #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janrtvld
force-pushed
the
feat/oobexport
branch
from
3e5dd33
to
bf96db0
Compare
|
@janrtvld your DCO sign-off failed. https://github.com/hyperledger/aries-framework-javascript/pull/990/checks?check_run_id=7989213031 Could you fix it? |
berendsliedrecht
approved these changes
Aug 24, 2022
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com>
janrtvld
force-pushed
the
feat/oobexport
branch
from
c1d8bc9
to
543a8ce
Compare
I was about to merge it but I have a doubt: is it OK the sign-off with *@users.noreply.github.com or should it be signed-off with an actual e-mail account? |
I don't think it matter much here. |
genaris
added a commit
to 2060-io/aries-framework-javascript
that referenced
this pull request
Sep 2, 2022
Signed-off-by: Ariel Gentile <gentilester@gmail.com> fix: expose oob domain (openwallet-foundation#990) fix: some changes based on feedback Signed-off-by: Ariel Gentile <gentilester@gmail.com> docs: a few clarifications and TODOs Signed-off-by: Ariel Gentile <gentilester@gmail.com> feat: combine features Signed-off-by: Ariel Gentile <gentilester@gmail.com> test(credentials): fix flaky tests with events (openwallet-foundation#966) Signed-off-by: 2byrds <2byrds@gmail.com> feat: OOB public did (openwallet-foundation#930) Signed-off-by: Pavel Zarecky <zarecky@procivis.ch> feat(routing): manual mediator pickup lifecycle management (openwallet-foundation#989) Signed-off-by: Ariel Gentile <gentilester@gmail.com> docs(demo): faber creates invitation (openwallet-foundation#995) Signed-off-by: conanoc <conanoc@gmail.com> chore(release): v0.2.3 (openwallet-foundation#999) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: disclosures message fields and optional thid Signed-off-by: Ariel Gentile <gentilester@gmail.com> fix(question-answer): question answer protocol state/role check (openwallet-foundation#1001) Signed-off-by: Ariel Gentile <gentilester@gmail.com> refactor: move feature registration to module Signed-off-by: Ariel Gentile <gentilester@gmail.com> fix: dependency manager test Signed-off-by: Ariel Gentile <gentilester@gmail.com> fix: feature registry instance Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.