fix(connections): allow ; to convert legacy did #882
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 468 468
Lines 11092 11095 +3
Branches 1745 1746 +1
=======================================
+ Hits 9715 9718 +3
Misses 1377 1377
Continue to review full report at Codecov.
|
Signed-off-by: Timo Glastra <timo@animo.id>
| const [, id] = fullId.split('#') | ||
| // Some old dids use `;` as the delimiter for the id. If we can't find a `#` | ||
| // and a `;` exists, we will parse everything after `;` as the id. | ||
| if (!fullId.includes('#') && fullId.includes(';')) { |
There was a problem hiding this comment.
This parser only works if there is a single ; in the id. Is that correct?
There was a problem hiding this comment.
The only usage I've seen is with one ;. I think it was used before the # and you can only include one. What we could do is leave the other ones in place (like url parsers do):
So we would get #indy;anotherword instead of #indy if the id was something;indy;anotherword. Do you think that is better?
There was a problem hiding this comment.
I think leaving them behind, which follows the url parser you showed, is good. I am very unaware of the security implications (likely none) here though.
packages/core/src/modules/connections/__tests__/ConnectionService.test.ts
Show resolved
Hide resolved
Signed-off-by: Timo Glastra <timo@animo.id>
Older dids use
;as an identifier separator instead of the now used#. So an id ofdid:sov:123;indywould be normalized to#did:sov:123;indy. We now check when converting a legacy did doc to a new did doc whether an;character is in place and the#isn't and we will handle it correclty so it parses to#indy