Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete credentials #770

Merged
merged 17 commits into from
May 19, 2022
Merged

fix: delete credentials #770

merged 17 commits into from
May 19, 2022

Commits on May 11, 2022

  1. Fix delete credentials 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d481577 View commit details
    Browse the repository at this point in the history

  2. Refactor test to use issueCredential from helper 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9cc7393 View commit details
    Browse the repository at this point in the history

  3. Add check on trying to delete already deleted credential 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9aceee1 View commit details
    Browse the repository at this point in the history

  4. Add check on trying to delete already deleted credential 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a8ace7b View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Delete Credentials further changes 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b6c9154 View commit details
    Browse the repository at this point in the history

  2. Fix lint warnings 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 12, 2022
    Configuration menu
    Copy the full SHA
    721dde7 View commit details
    Browse the repository at this point in the history

  3. Changes per PR review comments 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 12, 2022
    Configuration menu
    Copy the full SHA
    a4f5b8d View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Remove need to retrieve credential record twice 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    851045a View commit details
    Browse the repository at this point in the history

  2. Fix conflicts 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    2a8f2e8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hyperledger-main2' into fix/delete-credentials

    @NB-MikeRichardson
    NB-MikeRichardson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    454f352 View commit details
    Browse the repository at this point in the history

  4. Move recovation variables back into Default tags 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 13, 2022
    Configuration menu
    Copy the full SHA
    cdfd05c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Further fixes 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 16, 2022
    Configuration menu
    Copy the full SHA
    4a0f34e View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Merge branch 'main' into fix/delete-credentials

    @TimoGlastra
    TimoGlastra committed May 17, 2022
    Configuration menu
    Copy the full SHA
    ab075b6 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Merge branch 'main' into fix/delete-credentials

    @TimoGlastra
    TimoGlastra committed May 18, 2022
    Configuration menu
    Copy the full SHA
    393e9db View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/delete-credentials

    @TimoGlastra
    TimoGlastra committed May 18, 2022
    Configuration menu
    Copy the full SHA
    735642f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. fix failing test 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 19, 2022
    Configuration menu
    Copy the full SHA
    b195ba7 View commit details
    Browse the repository at this point in the history

  2. Fix Failing Test 

    Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
    @NB-MikeRichardson
    NB-MikeRichardson committed May 19, 2022
    Configuration menu
    Copy the full SHA
    8c89a34 View commit details
    Browse the repository at this point in the history