Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generic attachment handler #578

Commits on Dec 14, 2021

  1. wip: feat: generic attachment handler

    Adds method getDataAsJson to Attachment data and therefore also to Attachment.data
    This return the attachmnt data as JSON if .json or .base64 are present in attachmentdata.
    Otherwise it throws an error.
    
    Co-authored-by: annelein <anneleinvanreijen@gmail.com>
    
    Signed-off-by: morrieinmaas <moritz@animo.id>
    morrieinmaas committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    92acbb6 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. feat: generic attachment handler

    fixed fct declaration and henceforth tests
    
    Co-authored-by: annelein <anneleinvanreijen@gmail.com>
    
    Signed-off-by: morrieinmaas <moritz@animo.id>
    morrieinmaas committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    5dd353b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c4c442 View commit details
    Browse the repository at this point in the history
  3. feat: generic attachment handler

    Signed-off-by: annelein <anneleinvanreijen@gmail.com>
    Annelein committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    c743be2 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. chore: address code review feedback

    Better typing/function signatures
    
    Co-authored-by: annelein <anneleinvanreijen@gmail.com>
    
    Signed-off-by: morrieinmaas <moritz@animo.id>
    morrieinmaas committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    74558ec View commit details
    Browse the repository at this point in the history
  2. chore: merge remote

    Merge branch 'feat/generic-attachment-handler' of github.com:morrieinmaas/aries-framework-javascript into feat/generic-attachment-handler
    
    Signed-off-by: morrieinmaas <moritz@animo.id>
    morrieinmaas committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    8df7f43 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2fe98dd View commit details
    Browse the repository at this point in the history