Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove isPositive validation decorators #477

Merged

Conversation

TimoGlastra
Copy link
Contributor

Assumption was that isPositive would check for >= 0, but not negative,
but in reality it checks for >= 1

Signed-off-by: Timo Glastra timo@animo.id

Assumption was that isPositive would check for >= 0, but not negative,
but in reality it checks for >= 1

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner October 4, 2021 08:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #477 (b12b4ad) into main (cb256ca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         254      254           
  Lines        5516     5516           
  Branches      892      892           
=======================================
  Hits         4730     4730           
  Misses        785      785           
  Partials        1        1           
Impacted Files Coverage Δ
...ages/core/src/decorators/thread/ThreadDecorator.ts 100.00% <100.00%> (ø)
...s/core/src/modules/proofs/models/ProofAttribute.ts 72.72% <100.00%> (ø)
...re/src/modules/proofs/models/RequestedAttribute.ts 100.00% <100.00%> (ø)
...re/src/modules/proofs/models/RequestedPredicate.ts 100.00% <100.00%> (ø)
...src/modules/routing/messages/BatchPickupMessage.ts 58.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb256ca...b12b4ad. Read the comment docs.

@TimoGlastra TimoGlastra merged commit e316e04 into openwallet-foundation:main Oct 4, 2021
@TimoGlastra TimoGlastra deleted the fix/positive-checks branch October 4, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants