fix: anoncreds w3c migration metadata #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
auer-martin
force-pushed
the
fix/anoncreds-w3c-migration-meta
branch
from
0684eca
to
30e6b5b
Compare
TimoGlastra
reviewed
Mar 27, 2024
Comment on lines
+99
to
+101
| for (const [key, meta] of Object.entries(legacyRecord.metadata.data)) { | ||
| w3cCredentialRecord.metadata.set(key, meta) | ||
| } |
There was a problem hiding this comment.
Is there any metadata that can clash? I.e. metadata fields on the W3C record? Or do we set those after so it should be good?
Or are there any metadata fields that were on anoncreds record, but not needed anymore on the w3c record (the ones we created with _anoncreds and _internal prefixes?
There was a problem hiding this comment.
the new w3c-anoncreds metadata is set afterward, so that should not be a problem.
I did a quick check for metadata but could not find anything.
TimoGlastra
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.