Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: corrected some mistakes on demo documentation #1215

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

GramThanos
Copy link
Contributor

The link to the Nodejs prerequisites is invalid (missing a slash) and also outdated.

Signed-off-by: Grammatopoulos Athanasios Vasileios <GramThanos@users.noreply.github.com>
@GramThanos GramThanos requested a review from a team as a code owner January 16, 2023 10:47
@GramThanos GramThanos changed the title Corrected invalid and outdated link. fix(doc): Corrected invalid and outdated link to Nodejs prerequisites Jan 16, 2023
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@TimoGlastra TimoGlastra changed the title fix(doc): Corrected invalid and outdated link to Nodejs prerequisites docs: corrected invalid and outdated link to Nodejs prerequisites Jan 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1215 (b5b8ce0) into main (c697716) will decrease coverage by 1.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
- Coverage   87.59%   86.38%   -1.22%     
==========================================
  Files         734      734              
  Lines       17400    17400              
  Branches     2928     2928              
==========================================
- Hits        15242    15031     -211     
- Misses       2016     2199     +183     
- Partials      142      170      +28     
Impacted Files Coverage Δ
...atures/src/signature-suites/BbsBlsSignature2020.ts 4.23% <0.00%> (-83.06%) ⬇️
...es/bbs-signatures/src/Bls12381g2SigningProvider.ts 14.81% <0.00%> (-81.49%) ⬇️
...s/src/signature-suites/BbsBlsSignatureProof2020.ts 8.06% <0.00%> (-73.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Faber is generating the URL not Alice.

Signed-off-by: Grammatopoulos Athanasios Vasileios <GramThanos@users.noreply.github.com>
@GramThanos GramThanos changed the title docs: corrected invalid and outdated link to Nodejs prerequisites docs: corrected some mistakes on demo documentation Jan 16, 2023
@GramThanos
Copy link
Contributor Author

GramThanos commented Jan 16, 2023

There was one more small problem on the documentation.
Faber is the one able to Create connection invitation, not Alice.

One can see that Faber has the corresponding code:
https://github.com/hyperledger/aries-framework-javascript/blob/c697716bf1837b9fef307f60ff97f01d3d926728/demo/src/Faber.ts#L99

Signed-off-by: Grammatopoulos Athanasios Vasileios <GramThanos@users.noreply.github.com>
@TimoGlastra TimoGlastra enabled auto-merge (squash) January 17, 2023 13:00
@TimoGlastra TimoGlastra merged commit 409d36c into openwallet-foundation:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants