fix(connections): use new did for each connection from reusable invitation #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation When manually accepting a connection request (either connection or did-exchange) with a reusable invitation the same keys would be used in each did response. For auto accept routing was correctly configured to create new keys for each connection. This aligns the manual flow with the auto accept flow Signed-off-by: Timo Glastra <timo@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #1174 +/- ##
=======================================
Coverage ? 87.54%
=======================================
Files ? 706
Lines ? 16536
Branches ? 2805
=======================================
Hits ? 14477
Misses ? 1922
Partials ? 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
genaris
approved these changes
Dec 20, 2022
genaris
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manually accepting a connection request (either connection or did-exchange) with a reusable invitation the same keys would be used in each did response. For auto accept routing was correctly configured to create new keys for each connection. This aligns the manual flow with the auto accept flow
Signed-off-by: Timo Glastra timo@animo.id