fix: credential values encoding #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
approved these changes
Dec 13, 2022
|
Same here, I can't update the branch if you create the PR from an organization |
Signed-off-by: Łukasz Przytuła <lprzytula@gmail.com>
Przytua
force-pushed
the
fix/credential-values-encoding
branch
from
066e308 to
ca92bc9
Compare
|
@TimoGlastra updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Łukasz Przytuła lprzytula@gmail.com
String values containing round decimal numbers (for example
1.0,6.0) were encoded as a number (into1and6respectively) instead of properly hashing the string value, which causes issues with accepting credentials containing such values, issued by aca-py.