-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(proofs)!: rename ProofRecord to ProofExchangeRecord #1071
refactor(proofs)!: rename ProofRecord to ProofExchangeRecord #1071
Conversation
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some small suggestions but otherwise LGTM!
packages/core/src/storage/migration/__tests__/__snapshots__/0.2.test.ts.snap
Show resolved
Hide resolved
packages/core/src/modules/proofs/repository/ProofExchangeRecord.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
This refactoring would represent a breaking change, right? In that case I'll note it for the migration guide. Would it be merged as refactor(proofs)!: Rename ProofRecord to ProofExchangeRecord? |
@NB-MikeRichardson CI is failing it seems. I think you need to regenerate the snapshot files |
I'll take a look |
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
…dson/aries-framework-javascript into refactor/issue1058
Codecov Report
@@ Coverage Diff @@
## main #1071 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 679 679
Lines 15901 15901
Branches 2571 2571
=======================================
Hits 14028 14028
Misses 1865 1865
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
No description provided.