Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proofs)!: rename ProofRecord to ProofExchangeRecord #1071

Merged

Conversation

NB-MikeRichardson
Copy link
Contributor

No description provided.

Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
@NB-MikeRichardson NB-MikeRichardson requested a review from a team as a code owner October 25, 2022 09:47
@NB-MikeRichardson NB-MikeRichardson changed the title refactor (proofs): Rename ProofRecord to ProofExchangeRecord refactor(proofs): Rename ProofRecord to ProofExchangeRecord Oct 25, 2022
@NB-MikeRichardson NB-MikeRichardson changed the title refactor(proofs): Rename ProofRecord to ProofExchangeRecord refactor: Rename ProofRecord to ProofExchangeRecord Oct 25, 2022
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some small suggestions but otherwise LGTM!

NB-MikeRichardson and others added 2 commits October 25, 2022 13:19
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
@genaris
Copy link
Contributor

genaris commented Oct 25, 2022

This refactoring would represent a breaking change, right? In that case I'll note it for the migration guide. Would it be merged as refactor(proofs)!: Rename ProofRecord to ProofExchangeRecord?

@TimoGlastra TimoGlastra changed the title refactor: Rename ProofRecord to ProofExchangeRecord refactor(proofs)!: rename ProofRecord to ProofExchangeRecord Oct 25, 2022
@TimoGlastra
Copy link
Contributor

TimoGlastra commented Oct 25, 2022

@NB-MikeRichardson CI is failing it seems. I think you need to regenerate the snapshot files

@NB-MikeRichardson
Copy link
Contributor Author

@NB-MikeRichardson CI is failing it seems. I think you need to regenerate the snapshot files

I'll take a look

@codecov-commenter
Copy link

Codecov Report

Merging #1071 (5ed227b) into main (d4fd1ae) will not change coverage.
The diff coverage is 83.60%.

@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   88.22%   88.22%           
=======================================
  Files         679      679           
  Lines       15901    15901           
  Branches     2571     2571           
=======================================
  Hits        14028    14028           
  Misses       1865     1865           
  Partials        8        8           
Impacted Files Coverage Δ
packages/core/src/modules/proofs/ProofEvents.ts 100.00% <ø> (ø)
...otocol/v1/handlers/V1ProposePresentationHandler.ts 84.61% <ø> (ø)
...otocol/v1/handlers/V1RequestPresentationHandler.ts 88.09% <ø> (ø)
...otocol/v2/handlers/V2ProposePresentationHandler.ts 81.25% <ø> (ø)
...otocol/v2/handlers/V2RequestPresentationHandler.ts 96.96% <ø> (ø)
packages/core/src/modules/proofs/ProofsApi.ts 85.26% <57.14%> (ø)
packages/core/src/modules/proofs/ProofService.ts 64.51% <66.66%> (ø)
...e/src/modules/proofs/protocol/v1/V1ProofService.ts 80.40% <83.33%> (ø)
...e/src/modules/proofs/protocol/v2/V2ProofService.ts 87.57% <90.90%> (ø)
...ore/src/modules/proofs/ProofResponseCoordinator.ts 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TimoGlastra TimoGlastra merged commit f777b3d into openwallet-foundation:main Oct 25, 2022
@NB-MikeRichardson NB-MikeRichardson deleted the refactor/issue1058 branch October 26, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants