Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proofs): proofs module migration script for 0.3.0 #1020

Conversation

TimoGlastra
Copy link
Contributor

Fixes #996

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner September 8, 2022 19:58
@TimoGlastra TimoGlastra linked an issue Sep 8, 2022 that may be closed by this pull request
@genaris genaris added the 0.3.0 Changes for the 0.3.0 release label Sep 9, 2022
@genaris genaris added this to the v0.3.0 milestone Sep 9, 2022
@genaris genaris removed the 0.3.0 Changes for the 0.3.0 release label Sep 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #1020 (f06339f) into 0.3.0-pre (82a17a3) will increase coverage by 0.04%.
The diff coverage is 97.87%.

@@              Coverage Diff              @@
##           0.3.0-pre    #1020      +/-   ##
=============================================
+ Coverage      88.23%   88.28%   +0.04%     
=============================================
  Files            637      639       +2     
  Lines          15092    15172      +80     
  Branches        2542     2566      +24     
=============================================
+ Hits           13316    13394      +78     
- Misses          1678     1680       +2     
  Partials          98       98              
Impacted Files Coverage Δ
.../core/src/modules/proofs/repository/ProofRecord.ts 81.25% <ø> (ø)
...ages/core/src/storage/migration/UpdateAssistant.ts 89.32% <92.59%> (-0.10%) ⬇️
...core/src/storage/migration/StorageUpdateService.ts 100.00% <100.00%> (ø)
packages/core/src/storage/migration/updates.ts 100.00% <100.00%> (ø)
...ore/src/storage/migration/updates/0.2-0.3/index.ts 100.00% <100.00%> (ø)
...ore/src/storage/migration/updates/0.2-0.3/proof.ts 100.00% <100.00%> (ø)
packages/core/src/utils/version.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some very small comments regarding version constants and consistency with 0.1 migration test.

Interesting this new updateToVersion parameter for update. Do you see it useful not only for tests but also for some specific cases where the framework consumer wants to do this update process step by step? A possible scenario can be huge wallets where each step can take significant time and prefer to have a log or feedback more often.

@TimoGlastra
Copy link
Contributor Author

Interesting this new updateToVersion parameter for update. Do you see it useful not only for tests but also for some specific cases where the framework consumer wants to do this update process step by step? A possible scenario can be huge wallets where each step can take significant time and prefer to have a log or feedback more often.

I initially implemented it because I wanted to be able to test a single update (0.1 to 0.2, and in future others). However I do think it can be useful in mobile wallets to show a loading screen where you update per version, and get more insights into the process. A better way to do this would be by adding a progress object that you can see currentVersion / totalVersions and a percentage or something, but that would be more work to implement.

@TimoGlastra TimoGlastra merged commit 5e9e0fc into openwallet-foundation:0.3.0-pre Sep 22, 2022
@TimoGlastra TimoGlastra deleted the feat/proofs-migration-script branch September 22, 2022 10:07
genaris pushed a commit to 2060-io/aries-framework-javascript that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write migration script for present proof in 0.3.0
3 participants