-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(proofs): proofs module migration script for 0.3.0 #1020
feat(proofs): proofs module migration script for 0.3.0 #1020
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Codecov Report
@@ Coverage Diff @@
## 0.3.0-pre #1020 +/- ##
=============================================
+ Coverage 88.23% 88.28% +0.04%
=============================================
Files 637 639 +2
Lines 15092 15172 +80
Branches 2542 2566 +24
=============================================
+ Hits 13316 13394 +78
- Misses 1678 1680 +2
Partials 98 98
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some very small comments regarding version constants and consistency with 0.1 migration test.
Interesting this new updateToVersion
parameter for update. Do you see it useful not only for tests but also for some specific cases where the framework consumer wants to do this update process step by step? A possible scenario can be huge wallets where each step can take significant time and prefer to have a log or feedback more often.
packages/core/src/storage/migration/__tests__/UpdateAssistant.test.ts
Outdated
Show resolved
Hide resolved
I initially implemented it because I wanted to be able to test a single update (0.1 to 0.2, and in future others). However I do think it can be useful in mobile wallets to show a loading screen where you update per version, and get more insights into the process. A better way to do this would be by adding a progress object that you can see currentVersion / totalVersions and a percentage or something, but that would be more work to implement. |
Signed-off-by: Timo Glastra <timo@animo.id>
…undation#1020) Signed-off-by: Timo Glastra <timo@animo.id>
Fixes #996