bug: credential preview attributes mismatch schema attributes

Signed-off-by: annelein <anneleinvanreijen@gmail.com>
openwallet-foundation · Feb 7, 2022 · ea2aa64 · ea2aa64
1 parent beff6b0
commit ea2aa64
Showing 1 changed file with 22 additions and 0 deletions.
diff --git a/packages/core/src/modules/credentials/services/CredentialService.ts b/packages/core/src/modules/credentials/services/CredentialService.ts
@@ -244,6 +244,17 @@ export class CredentialService {
       }),
     })
 
+    // Check if credential preview attributes match the schema attributes
+    const schema = await this.ledgerService.getSchema(credOffer.schema_id)
+    const credAttributes = credentialTemplate.preview.attributes
+    const schemaAttribute = schema.attrNames
+
+    credAttributes.forEach((credAtrr) => {
+      if (schemaAttribute.indexOf(credAtrr.name) === -1) {
+        throw new AriesFrameworkError(`The credential preview attributes do not match the schema attributes`)
+      }
+    })
+
     const credentialOfferMessage = new OfferCredentialMessage({
       comment,
       offerAttachments: [offerAttachment],
@@ -297,6 +308,17 @@ export class CredentialService {
       }),
     })
 
+    // Check if credential preview attributes match the schema attributes
+    const schema = await this.ledgerService.getSchema(credOffer.schema_id)
+    const credAttributes = credentialTemplate.preview.attributes
+    const schemaAttribute = schema.attrNames
+
+    credAttributes.forEach((credAtrr) => {
+      if (schemaAttribute.indexOf(credAtrr.name) === -1) {
+        throw new AriesFrameworkError(`The credential preview attributes do not match the schema attributes`)
+      }
+    })
+
     // Create and link credential to attacment
     const credentialPreview = linkedAttachments
       ? CredentialUtils.createAndLinkAttachmentsToPreview(linkedAttachments, preview)