fix: do not import test logger in src (#746)

Signed-off-by: Timo Glastra <timo@animo.id>
openwallet-foundation · May 6, 2022 · 5c80004 · 5c80004
1 parent 245223a
commit 5c80004
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 10 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -68,9 +68,12 @@ jobs:
       - name: Prettier
         run: yarn check-format
 
-      - name: Compile
+      - name: Check Types
         run: yarn check-types
 
+      - name: Compile
+        run: yarn build
+
   integration-test:
     runs-on: ubuntu-20.04
     name: Integration Tests

diff --git a/packages/core/src/modules/credentials/__tests__/V1CredentialService.cred.test.ts b/packages/core/src/modules/credentials/__tests__/V1CredentialService.cred.test.ts
@@ -266,7 +266,8 @@ describe('CredentialService', () => {
         eventEmitter,
         indyIssuerService,
         indyLedgerService,
-        indyHolderService
+        indyHolderService,
+        agentConfig
       ),
       revocationService
     )

diff --git a/packages/core/src/modules/credentials/__tests__/V1CredentialService.offer.test.ts b/packages/core/src/modules/credentials/__tests__/V1CredentialService.offer.test.ts
@@ -118,7 +118,8 @@ describe('CredentialService', () => {
         eventEmitter,
         indyIssuerService,
         indyLedgerService,
-        indyHolderService
+        indyHolderService,
+        agentConfig
       ),
       revocationService
     )
@@ -289,7 +290,8 @@ describe('CredentialService', () => {
           eventEmitter,
           indyIssuerService,
           indyLedgerService,
-          indyHolderService
+          indyHolderService,
+          agentConfig
         ),
         revocationService
       )

diff --git a/packages/core/src/modules/credentials/__tests__/V2CredentialService.cred.test.ts b/packages/core/src/modules/credentials/__tests__/V2CredentialService.cred.test.ts
@@ -260,7 +260,8 @@ describe('CredentialService', () => {
         eventEmitter,
         indyIssuerService,
         indyLedgerService,
-        indyHolderService
+        indyHolderService,
+        agentConfig
       ),
       revocationService
     )

diff --git a/packages/core/src/modules/credentials/__tests__/V2CredentialService.offer.test.ts b/packages/core/src/modules/credentials/__tests__/V2CredentialService.offer.test.ts
@@ -117,7 +117,8 @@ describe('CredentialService', () => {
         eventEmitter,
         indyIssuerService,
         indyLedgerService,
-        indyHolderService
+        indyHolderService,
+        agentConfig
       ),
       revocationService
     )
@@ -307,7 +308,8 @@ describe('CredentialService', () => {
           eventEmitter,
           indyIssuerService,
           indyLedgerService,
-          indyHolderService
+          indyHolderService,
+          agentConfig
         ),
         revocationService
       )

diff --git a/packages/core/src/modules/credentials/formats/indy/IndyCredentialFormatService.ts b/packages/core/src/modules/credentials/formats/indy/IndyCredentialFormatService.ts
@@ -1,4 +1,5 @@
 import type { Attachment } from '../../../../decorators/attachment/Attachment'
+import type { Logger } from '../../../../logger'
 import type {
   NegotiateProposalOptions,
   OfferCredentialOptions,
@@ -32,7 +33,7 @@ import { Lifecycle, scoped } from 'tsyringe'
 
 import { AriesFrameworkError } from '../../../../../src/error'
 import { MessageValidator } from '../../../../../src/utils/MessageValidator'
-import logger from '../../../../../tests/logger'
+import { AgentConfig } from '../../../../agent/AgentConfig'
 import { EventEmitter } from '../../../../agent/EventEmitter'
 import { uuid } from '../../../../utils/uuid'
 import { IndyHolderService, IndyIssuerService } from '../../../indy'
@@ -53,19 +54,22 @@ export class IndyCredentialFormatService extends CredentialFormatService {
   private indyLedgerService: IndyLedgerService
   private indyHolderService: IndyHolderService
   protected credentialRepository: CredentialRepository // protected as in base class
+  private logger: Logger
 
   public constructor(
     credentialRepository: CredentialRepository,
     eventEmitter: EventEmitter,
     indyIssuerService: IndyIssuerService,
     indyLedgerService: IndyLedgerService,
-    indyHolderService: IndyHolderService
+    indyHolderService: IndyHolderService,
+    agentConfig: AgentConfig
   ) {
     super(credentialRepository, eventEmitter)
     this.credentialRepository = credentialRepository
     this.indyIssuerService = indyIssuerService
     this.indyLedgerService = indyLedgerService
     this.indyHolderService = indyHolderService
+    this.logger = agentConfig.logger
   }
 
   /**
@@ -156,7 +160,7 @@ export class IndyCredentialFormatService extends CredentialFormatService {
     if (!attachment) {
       throw new AriesFrameworkError('Missing offer attachment in processOffer')
     }
-    logger.debug(`Save metadata for credential record ${credentialRecord.id}`)
+    this.logger.debug(`Save metadata for credential record ${credentialRecord.id}`)
 
     const credOffer: CredOffer = attachment.getDataAsJson<CredOffer>()