Upgrade React Native #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com>
Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com>
Signed-off-by: NeilSMyers <mmyersneil@gmail.com>
NeilSMyers
previously approved these changes
May 19, 2021
App.js
Outdated
| @@ -25,6 +25,10 @@ const App = (props) => { | |||
| let location = useLocation() | |||
| let history = useHistory() | |||
|
|
|||
| useEffect(()=>{ | |||
| console.log("Hermes enabled:", !!global.HermesInternal) | |||
There was a problem hiding this comment.
do we keep these kind of console.logs in?
There was a problem hiding this comment.
No, we should remove this log IMO
JamesKEbert
suggested changes
May 19, 2021
There was a problem hiding this comment.
@NeilSMyers could you fix the merge conflict with the podfile lock? Removing that log would probably also be helpful.
Signed-off-by: NeilSMyers <mmyersneil@gmail.com>
JamesKEbert
approved these changes
May 19, 2021
There was a problem hiding this comment.
This is great. Thanks for your efforts here @TheTreek and @NeilSMyers
JamesKEbert
pushed a commit
that referenced
this pull request
May 24, 2021
* feat: updated qr code scanner to work with ios (#44) * feat: updated qr code scanner to work with ios Signed-off-by: seajensen <seajensen@gmail.com> * feat: fixed style formatting Signed-off-by: seajensen <seajensen@gmail.com> * Upgrade React Native (#45) * Upgraded from 0.61.5 to 0.64.1 Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * Enabled hermes Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * connected indy framework Signed-off-by: NeilSMyers <mmyersneil@gmail.com> Co-authored-by: NeilSMyers <mmyersneil@gmail.com> * base aries store setup with counter slice Signed-off-by: NeilSMyers <mmyersneil@gmail.com> Co-authored-by: seajensen <seajensen@gmail.com> Co-authored-by: Patrick Kenyon <treek.kenyon@gmail.com>
jcdrouin21
pushed a commit
to MCN-ING/aries-mobile-agent-react-native
that referenced
this pull request
May 16, 2023
…allet-proof BC Wallet proof test dev - Working Happy Path test scenarios for proofs in the BC Wallet.
jcdrouin21
pushed a commit
to MCN-ING/aries-mobile-agent-react-native
that referenced
this pull request
May 16, 2023
…on-in-ci different way to start sauce connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updated React Native to 0.64.1 and enabled hermes
Related Issues
hyperledger-archives/indy-sdk#2346
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this).npm run style-formatIf you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template adapted from the Python attrs project.