-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: w3c anoncreds support #1115
feat: w3c anoncreds support #1115
Conversation
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
14ccc06
to
04f8371
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @auer-martin
packages/legacy/core/__tests__/screens/CredentialDetails.test.tsx
Outdated
Show resolved
Hide resolved
Could you add a video demo where an AnonCreds credential is received using Data Integrity and shared using Presentation Exhcange? |
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
cae5469
to
48fdf24
Compare
|
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
dedb083
to
f7722b4
Compare
@auer-martin Able to fix the two conflict and well get this merged in? |
fix: tests Signed-off-by: Martin Auer <martin.auer97@gmail.com>
4648216
to
965ccdd
Compare
@jleach done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I have some questions about the index file but other than that it looks great
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
40aa541
to
c8d3935
Compare
it seems like the change is not backwards compatible to indy credentials. I'm getting the following error whenever I try and get an indy credential:
here is the demo you can use to get some example indy credentials: https://digital.gov.bc.ca/digital-trust/showcase/ |
…cy ids) Signed-off-by: Martin Auer <martin.auer97@gmail.com>
cbcb497
to
c36a828
Compare
Nice catch! There was an issue in credo-ts that caused this. I updated the PR to use the latest credo alpha, and tested issuing and verifying with the bcgov demo, and it works now. 👍🏻 |
@wadeking98 BTW it's OK to be on an alpha version for now. We'll be releasing 0.5.2 soon, and will make a follow up PR then to the stable version |
okay sounds good, I'll do some testing in a bit and then we'll get this merged! |
Okay seems to be working well in bifold, I'm still running into an issue when I link it to bc wallet but I think that must be an issue with some configuration on our end. Great work LGTM |
Summary of Changes
Add support for receiving w3c-anoncreds credentials via the new DataIntegrity attachment format
Add support for rendering dif pex presentation requests using the existing rendering logic
Add support for presenting credentials via PresentationExchange
Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.