-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust permissions to support uniffi module outside the repo #175
Changes from 2 commits
ff0bb53
fc49a5f
d0efe6f
cda9162
b989dcc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
//! Error types | ||
use std::error::Error as StdError; | ||
use std::fmt::{self, Display, Formatter}; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
#![deny(missing_docs, missing_debug_implementations, rust_2018_idioms)] | ||
|
||
#[macro_use] | ||
mod error; | ||
pub mod error; | ||
andrewwhitehead marked this conversation as resolved.
Show resolved
Hide resolved
|
||
pub use self::error::{Error, ErrorKind}; | ||
|
||
#[cfg(any(test, feature = "log"))] | ||
|
@@ -22,9 +22,9 @@ pub use askar_storage as storage; | |
pub use askar_storage::future; | ||
|
||
#[cfg(feature = "ffi")] | ||
mod ffi; | ||
pub mod ffi; | ||
conanoc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
pub mod kms; | ||
|
||
mod store; | ||
pub mod store; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's in the store module that's not being exposed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the symbols I use from store. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't you just There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah. It works. |
||
pub use store::{entry, PassKey, Session, Store, StoreKeyMethod}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
//! module for askar store and session | ||
use askar_storage::backend::copy_profile; | ||
|
||
use crate::{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could return a slice to avoid exposing implementation details:
self.tags.as_slice()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.