Skip to content

Commit

Permalink
netdev-dpdk: Disable outer udp checksum offload for txgbe driver.
Browse files Browse the repository at this point in the history
Fixing the issue of incorrect outer UDP checksum in packets sent by
the wangxun network card (driver is txgbe), we disabled
RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.

Fixes: 084c808 ("userspace: Support VXLAN and GENEVE TSO.")
Reported-by: Jun Wang <junwang01@cestc.cn>

Acked-by: David Marchand <david.marchand@redhat.com>
Acked-by: Simon Horman <horms@ovn.org>
Signed-off-by: Jun Wang <junwang01@cestc.cn>
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
  • Loading branch information
wangjun0728 authored and chaudron committed Sep 23, 2024
1 parent e05a769 commit d17dbcc
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/netdev-dpdk.c
Original file line number Diff line number Diff line change
Expand Up @@ -1355,12 +1355,13 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)

if (!strcmp(info.driver_name, "net_ice")
|| !strcmp(info.driver_name, "net_i40e")
|| !strcmp(info.driver_name, "net_iavf")) {
|| !strcmp(info.driver_name, "net_iavf")
|| !strcmp(info.driver_name, "net_txgbe")) {
/* FIXME: Driver advertises the capability but doesn't seem
* to actually support it correctly. Can remove this once
* the driver is fixed on DPDK side. */
VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a "
"net/ice, net/i40e or net/iavf port.",
"net/ice, net/i40e, net/iavf or net/txgbe port.",
netdev_get_name(&dev->up));
info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO;
Expand Down

0 comments on commit d17dbcc

Please sign in to comment.