Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix small space leak #784

Merged
merged 2 commits into from
Aug 11, 2017
Merged

fix small space leak #784

merged 2 commits into from
Aug 11, 2017

Conversation

toolslive
Copy link
Member

No description provided.

domsj
domsj reviewed Aug 11, 2017
View reviewed changes
Copy link
Contributor

@domsj domsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Fwiw I think there's a similar issue in the erasure decode path too:

       let rsm = Ctypes.(bigarray_start
                           array1
                           (Isa_l.rs_vandermonde_matrix_from_jerasure ~k ~rows:k dm)) in

Can you also fix that in this PR?

@toolslive toolslive merged commit 332d696 into master Aug 11, 2017
@toolslive toolslive deleted the rsm_space_leak branch August 11, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domsj domsj domsj approved these changes

Assignees
No one assigned
Labels
state_inprogress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toolslive @domsj @wimpers