Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify stress2 test + use tail recursive map everywhere #717

Merged
merged 4 commits into from
May 11, 2017
Merged

Conversation

domsj
Copy link
Contributor

@domsj domsj commented May 11, 2017

(all .ml files are as of now required to open! Prelude)

Copy link
Member

@toolslive toolslive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use List.fold_right or List.merge

@domsj domsj merged commit 8e67914 into master May 11, 2017
@domsj domsj deleted the stress2 branch May 11, 2017 13:45
@aantron
Copy link

aantron commented May 11, 2017

Let me know if you do decide that tail-recursive Lwt_list functions (ocsigen/lwt#347) are necessary. We can quickly add them. You should be able to pin to that Lwt commit, and it will also get released in the next release. We'll probably eventually switch to tail-recursive functions no matter what, once it's time to deal with "everything" in Lwt_list, which shouldn't be too far off.

@domsj
Copy link
Contributor Author

domsj commented May 12, 2017

We have included our own version of the Lwt_list functions ... see https://github.com/openvstorage/alba/blob/1.3.15/ocaml/src/tools/prelude.ml#L856, so no rush for a new release from our end.
As an fyi: the stress2 suite still periodically segfaults on my machine. But as it's only on my machine I'm starting to think it's a hardware problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants