Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anomaly task to OTX 1.6.x #3906

Conversation

ashwinvaidya17
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

ashwinvaidya17 and others added 12 commits August 12, 2024 16:11
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
…extensions into ashwin/anomaly_geti_task_migration_1_6
…shwinvaidya17/training_extensions into ashwin/anomaly_geti_task_migration_1_6
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
…shwinvaidya17/training_extensions into ashwin/anomaly_geti_task_migration_1_6
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
@ashwinvaidya17 ashwinvaidya17 requested a review from a team as a code owner August 28, 2024 12:51
@github-actions github-actions bot added API Any changes in OTX API CLI Any changes in OTE CLI ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Aug 28, 2024
@chuneuny-emily
Copy link
Contributor

Please do not merge this PR into releases/1.6.0 branch. This PR branch was just merged into aurelien/CVS-147615-Anomaly-reduction-documentation-update branch in Geti for early work on Geti side. Since this feature is targeting Geti 2.5, it should be merged in OTX2.2.x.

@@ -43,6 +43,7 @@
"ACTION_CLASSIFICATION": "Custom_Action_Classification_X3D",
"ACTION_DETECTION": "Custom_Action_Detection_X3D_FAST_RCNN",
"VISUAL_PROMPTING": "Visual_Prompting_SAM_ViT_B",
"ANOMALY": "otx_anomaly_padim",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is defined here but never used anywhere. Do you think if this is needed? Or the other model template ids updated?

@samet-akcay
Copy link
Contributor

Same as #3910, the detection tests are failing here. Any thoughts @harimkang ?

@harimkang
Copy link
Contributor

Same as #3910, the detection tests are failing here. Any thoughts @harimkang ?

I'm not sure about 1.6. @chuneuny-emily Can you give us some advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API CLI Any changes in OTE CLI TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants