Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot-fix rotated_detection configuration #3894

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

harimkang
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@harimkang harimkang requested a review from a team as a code owner August 26, 2024 06:35
@harimkang harimkang changed the title Update rotated_detection configuration Hot-fix rotated_detection configuration Aug 26, 2024
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Aug 26, 2024
sungchul2
sungchul2 previously approved these changes Aug 26, 2024
chuneuny-emily
chuneuny-emily previously approved these changes Aug 26, 2024
@chuneuny-emily chuneuny-emily enabled auto-merge (squash) August 26, 2024 06:37
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (f2d5476) to head (d5b9ddf).
Report is 1 commits behind head on releases/1.6.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.6.0    #3894      +/-   ##
==================================================
- Coverage           80.65%   80.64%   -0.01%     
==================================================
  Files                 536      536              
  Lines               40554    40554              
==================================================
- Hits                32708    32706       -2     
- Misses               7846     7848       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu
Copy link
Contributor

yunchu commented Aug 26, 2024

@harimkang please don't forget to add your changes to the CHANGELOG.md
if you missed it, we need to create another PR to update that.

@harimkang harimkang dismissed stale reviews from chuneuny-emily and sungchul2 via d5b9ddf August 26, 2024 07:25
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Aug 26, 2024
@harimkang
Copy link
Contributor Author

@harimkang please don't forget to add your changes to the CHANGELOG.md if you missed it, we need to create another PR to update that.

Thanks, i update it d5b9ddf

@chuneuny-emily chuneuny-emily merged commit 3f4c1e3 into releases/1.6.0 Aug 26, 2024
15 of 16 checks passed
@chuneuny-emily chuneuny-emily deleted the harimkan/rotated_detection_issues branch August 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants